-
Notifications
You must be signed in to change notification settings - Fork 924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update quill dependency to v2 #711
base: master
Are you sure you want to change the base?
Conversation
It looks like the API changes are small enough that we could potentially allow either version of Quill with some minor refactoring |
@alexkrolick we bundle Quill, so shipping two versions is not straightforward. Quill is currently in But I'd be ok adding support for it in either react-quill v1 and v2—with the user overriding the dependency manually via webpack. Are you aware of any issue preventing release of v2 so far? |
Yep, I was thinking bundling Quill v1 but handling v2 if it is installed via a package.json override. Looking at the issues, I don't see anything specific to our (react-quill)'s v2 beta, so I'd say it's ok to release as stable now and then do a 2.1.0 release later with the support for quill v2. There is some risk the v2 version eventually breaks react-quill in a larger way that would either another major version that drops v1, or a more complex workaround strategy. |
Are you still working on V2? |
A similar PR to #507 but for the latest version of react-quill, with no mixin.
Quill v2, while still being in development, has support for features such as tables and increased support for newer versions of Safari. While this might not be merged in until Quill v2 releases properly, at the moment it's useful to have it in some special cases.