custom_fields: enabling visibility on deposit form #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzacharo
reviewed
Jan 29, 2024
| "section": _("Audiovisual core"), | ||
| "icon": "camera", | ||
| "hide_from_upload_form": False, | ||
| "compose_fields": True, # marks the group as dynamic |
There was a problem hiding this comment.
We need a better naming for this :) Not sure what yet.....
There was a problem hiding this comment.
what about be more explicit and say something like
show_all_fields_by_defaultshow_fields_on_demandsearch_fields(kind of dropdown paradigm of show options vs search for options)
zzacharo
reviewed
Jan 29, 2024
| "section": _("Audiovisual core"), | ||
| "icon": "camera", | ||
| "hide_from_upload_form": False, | ||
| "compose_fields": True, # marks the group as dynamic |
There was a problem hiding this comment.
what about be more explicit and say something like
show_all_fields_by_defaultshow_fields_on_demandsearch_fields(kind of dropdown paradigm of show options vs search for options)
| # Custom fields UI components | ||
| CUSTOM_FIELDS_UI = [ | ||
| # codemeta | ||
| # CODEMETA_CUSTOM_FIELDS_UI, # TODO enable when fixed (see https://github.com/zenodo/rdm-project/issues/217) |
There was a problem hiding this comment.
does it make sense to check with @0einstein0 if we enable it to check if it's an easy fix?
There was a problem hiding this comment.
it was not meant as a part of this sprint if I understood correctly
| *AUDIOVIS_FIELDS, | ||
| # codemeta, | ||
| *CODEMETA_CUSTOM_FIELDS, | ||
| # TODO enable when fixed (see https://github.com/zenodo/rdm-project/issues/217) |
kpsherva
force-pushed
the
Custom-Fields
branch
2 times, most recently
from
397f4b4 to
28ab451
Compare
kpsherva
force-pushed
the
Custom-Fields
branch
from
28ab451 to
87584a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*closes https://github.com/zenodo/rdm-project/issues/649