-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RESTAPIHandler should return all ids as strings #1908
Comments
Hi @thomassnielsen , thanks, I see the inconsistency. Changing the RESTAPIHandler will result in a breaking change. For the time being, how about changing the openapi plugin to generate id field type as defined in the schema? It'll deviate from the JSON:API spec, but we can document that. |
That sounds good to me. |
We could also add a note in the docs that if full JSON:API spec compliance is important, one can use strings as ids in the schema. |
Sounds good. Thank you! |
Fixed in v2.11.0 |
Description and expected behavior
The RESTAPIHandler returns ids as whatever the type is in the db. But json:api requires ids to be strings. The OpenAPI plugin correctly requires ids to be strings, creating a mismatch between the docs and the implementation.
Environment:
The text was updated successfully, but these errors were encountered: