-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@zenstackhq/trpc : $Schema import compatibility update #1181
Conversation
WalkthroughWalkthroughThe modification in question involves a technical adjustment in the way the Changes
Related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (2)
packages/plugins/trpc/tests/projects/t3-trpc-v10/src/server/api/routers/generated/routers/Post.router.ts
is excluded by:!**/generated/**
packages/plugins/trpc/tests/projects/t3-trpc-v10/src/server/api/routers/generated/routers/User.router.ts
is excluded by:!**/generated/**
Files selected for processing (1)
- packages/plugins/trpc/src/helpers.ts (1 hunks)
Additional comments: 1
packages/plugins/trpc/src/helpers.ts (1)
- 241-241: The change to use a namespace import for
$Schema
aligns with the PR objectives and should improve compatibility and maintainability. Ensure that all usages of$Schema
throughout the project are updated to reflect this new import methodology.
Thank you @jbruxelle . The change looks great! I'll merge and include it in the upcoming release around the end of this week. |
π Changes related to #1177
$Schema
import to useimport * as
instead of default importβ Tests ran successfully
Summary by CodeRabbit
$Schema
in the router schema generation process to enhance compatibility and maintainability.