-
-
Notifications
You must be signed in to change notification settings - Fork 126
chore: no client generation when pushing db during test #1603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughWalkthroughThe recent changes primarily focus on the Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant SchemaManager
participant Database
Developer->>SchemaManager: loadSchema(schema, options)
SchemaManager->>Database: run('npx prisma db push --skip-generate')
Database-->>SchemaManager: Schema pushed without client generation
SchemaManager-->>Developer: Confirmation of schema update
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/testtools/src/schema.ts (1 hunks)
Additional comments not posted (1)
packages/testtools/src/schema.ts (1)
240-240: Verify the impact of the--skip-generateflag on the client code generation process.The addition of the
--skip-generateflag modifies the behavior of the Prisma command by preventing the automatic generation of client code after the database schema is pushed. Ensure that this change does not negatively impact the application and that proper testing is conducted to verify the expected behavior.
No description provided.