-
-
Notifications
You must be signed in to change notification settings - Fork 126
fix: use pnpm host mode to resolve tsc compatibility issues #1613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughWalkthroughThe recent update introduces the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant NPM
participant Project
User->>NPM: Install package
NPM->>Project: Resolve dependencies
Project->>NPM: Use node-linker=hoisted
NPM->>User: Complete installation
sequenceDiagram
participant Tester
participant Project
Tester->>Project: Instantiate Project
Project->>Compiler: Use skipLibCheck=true
Compiler->>Tester: Complete type checking
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .npmrc (1 hunks)
Additional comments not posted (1)
.npmrc (1)
3-3: Addition ofnode-linker=hoistedconfiguration.The new configuration option
node-linker=hoistedhas been added. This setting can improve dependency resolution and linking behavior, particularly in multi-package repositories. Ensure that this change is compatible with your project's requirements and does not introduce any unexpected issues in your development workflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- packages/plugins/trpc/src/project.ts (1 hunks)
- packages/schema/tests/generator/expression-writer.test.ts (1 hunks)
Additional comments not posted (2)
packages/plugins/trpc/src/project.ts (1)
9-9: Verify the impact ofskipLibCheck: true.Adding
skipLibCheck: truecan improve compilation speed but might hide some type errors in declaration files. Ensure this change does not introduce any hidden issues in the project.packages/schema/tests/generator/expression-writer.test.ts (1)
1335-1337: Verify the impact ofskipLibCheck: truein tests.Adding
skipLibCheck: truecan improve test compilation speed but might hide some type errors in declaration files. Ensure this change does not introduce any hidden issues in the tests.
No description provided.