fix(zmodel): validate @regex regular expression patterns

[ymc9]

No description provided.

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request introduces a new private method _checkRegex in the attribute application validator to handle regex pattern validation. The validator now retrieves a string literal from an attribute application and checks its validity as a regular expression. If the literal is missing or if the regex is malformed, the code reports an error using the provided validation acceptor. Additionally, new test cases have been added to verify both the error handling and the proper functioning of valid regex patterns.

Changes

File	Change Summary
packages/.../validator/attribute-application-validator.ts	Added a private _checkRegex method in the AttributeApplicationValidator class to validate regex patterns from attribute applications, checking for a valid string literal and catching errors during RegExp creation.
packages/.../validation/attribute-validation.test.ts	Added new tests for regex validation in attribute applications, ensuring that non-string literals and invalid regex formats trigger error messages, while valid regex patterns are recognized.

Sequence Diagram(s)

sequenceDiagram
    participant Validator as AttributeApplicationValidator
    participant AttrApp as AttributeApplication
    participant Acceptor as ValidationAcceptor
    Note over Validator: Start _checkRegex execution
    Validator->>AttrApp: Retrieve first argument value (as string literal)
    alt String literal undefined
        Validator->>Acceptor: Accept error "Expecting a string literal"
    else String literal exists
        Validator->>Validator: Attempt to create new RegExp(literal)
        alt RegExp constructor throws error
            Validator->>Acceptor: Accept error with exception message
        else RegExp constructed successfully
            Note over Validator: Validation passes with no error accepted
        end
    end

Loading

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 54a9b21 and b00ecb2.

📒 Files selected for processing (2)

• packages/schema/src/language-server/validator/attribute-application-validator.ts (1 hunks)
• packages/schema/tests/schema/validation/attribute-validation.test.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (6)

• GitHub Check: build-test (20.x)
• GitHub Check: build-test (20.x)
• GitHub Check: dependency-review
• GitHub Check: build-test (20.x)
• GitHub Check: OSSAR-Scan
• GitHub Check: Analyze (javascript-typescript)