-
-
Notifications
You must be signed in to change notification settings - Fork 125
fix(policy): revers lookup condition to parent entity is not properly built with compound id fields #2053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix(policy): revers lookup condition to parent entity is not properly built with compound id fields #2053
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
fb4a586
fix(policy): revers lookup condition to parent entity is not properly…
ymc9 a16bb9d
update test
ymc9 2826974
fix build
ymc9 4180576
update
ymc9 610c180
fix test
ymc9 935d539
fix undefined where conditions
ymc9 215e359
more tests
ymc9 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,128 @@ | ||
| import { loadSchema } from '@zenstackhq/testtools'; | ||
|
|
||
| describe('issue 1964', () => { | ||
| it('regression1', async () => { | ||
| const { enhance } = await loadSchema( | ||
| ` | ||
| model User { | ||
| id Int @id | ||
| orgId String | ||
| } | ||
|
|
||
| model Author { | ||
| id Int @id @default(autoincrement()) | ||
| orgId String | ||
| name String | ||
| posts Post[] | ||
|
|
||
| @@unique([orgId, name]) | ||
| @@allow('all', auth().orgId == orgId) | ||
| } | ||
|
|
||
| model Post { | ||
| id Int @id @default(autoincrement()) | ||
| orgId String | ||
| title String | ||
| author Author @relation(fields: [authorId], references: [id]) | ||
| authorId Int | ||
|
|
||
| @@allow('all', auth().orgId == orgId) | ||
| } | ||
| `, | ||
| { | ||
| previewFeatures: ['strictUndefinedChecks'], | ||
| } | ||
| ); | ||
|
|
||
| const db = enhance({ id: 1, orgId: 'org' }); | ||
|
|
||
| const newauthor = await db.author.create({ | ||
| data: { | ||
| name: `Foo ${Date.now()}`, | ||
| orgId: 'org', | ||
| posts: { | ||
| createMany: { data: [{ title: 'Hello', orgId: 'org' }] }, | ||
| }, | ||
| }, | ||
| include: { posts: true }, | ||
| }); | ||
|
|
||
| await expect( | ||
| db.author.update({ | ||
| where: { orgId_name: { orgId: 'org', name: newauthor.name } }, | ||
| data: { | ||
| name: `Bar ${Date.now()}`, | ||
| posts: { deleteMany: { id: { equals: newauthor.posts[0].id } } }, | ||
| }, | ||
| }) | ||
| ).toResolveTruthy(); | ||
| }); | ||
|
|
||
| it('regression2', async () => { | ||
| const { enhance } = await loadSchema( | ||
| ` | ||
| model User { | ||
| id Int @id @default(autoincrement()) | ||
| slug String @unique | ||
| profile Profile? | ||
| @@allow('all', true) | ||
| } | ||
|
|
||
| model Profile { | ||
| id Int @id @default(autoincrement()) | ||
| slug String @unique | ||
| name String | ||
| addresses Address[] | ||
| userId Int? @unique | ||
| user User? @relation(fields: [userId], references: [id]) | ||
| @@allow('all', true) | ||
| } | ||
|
|
||
| model Address { | ||
| id Int @id @default(autoincrement()) | ||
| profileId Int @unique | ||
| profile Profile @relation(fields: [profileId], references: [id]) | ||
| city String | ||
| @@allow('all', true) | ||
| } | ||
| `, | ||
| { | ||
| previewFeatures: ['strictUndefinedChecks'], | ||
| } | ||
| ); | ||
|
|
||
| const db = enhance({ id: 1, orgId: 'org' }); | ||
|
|
||
| await db.user.create({ | ||
| data: { | ||
| slug: `user1`, | ||
| profile: { | ||
| create: { | ||
| name: `My Profile`, | ||
| slug: 'profile1', | ||
| addresses: { | ||
| create: { id: 1, city: 'City' }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }); | ||
|
|
||
| await expect( | ||
| db.user.update({ | ||
| where: { slug: 'user1' }, | ||
| data: { | ||
| profile: { | ||
| update: { | ||
| addresses: { | ||
| deleteMany: { id: { equals: 1 } }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }) | ||
| ).toResolveTruthy(); | ||
|
|
||
| await expect(db.address.count()).resolves.toEqual(0); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.