Skip to content

fix(server-rest): filters at different hierarchies are not properly combined #2054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2025
Merged

fix(server-rest): filters at different hierarchies are not properly combined #2054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/server/src/api/rest/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1528,7 +1528,6 @@ class RequestHandler extends APIHandlerBase {
}

const items: any[] = [];
let currType = typeInfo;

for (const [key, value] of Object.entries(query)) {
if (!value) {
Expand All @@ -1554,6 +1553,7 @@ class RequestHandler extends APIHandlerBase {

const item: any = {};
let curr = item;
let currType = typeInfo;

for (const filterValue of enumerate(value)) {
for (let i = 0; i < filterKeys.length; i++) {
Expand Down
20 changes: 20 additions & 0 deletions packages/server/tests/api/rest.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,6 +633,26 @@ describe('REST server tests', () => {
prisma,
});
expect(r.body.data).toHaveLength(0);
r = await handler({
method: 'get',
path: '/post',
query: {
['filter[author][email]']: 'user1@abc.com',
['filter[title]']: 'Post1',
},
prisma,
});
expect(r.body.data).toHaveLength(1);
r = await handler({
method: 'get',
path: '/post',
query: {
['filter[author][email]']: 'user1@abc.com',
['filter[title]']: 'Post2',
},
prisma,
});
expect(r.body.data).toHaveLength(0);

// to-one relation filter
r = await handler({
Expand Down
Loading