-
-
Notifications
You must be signed in to change notification settings - Fork 126
chore: run tests with zod4 #2231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the 📝 WalkthroughWalkthroughUpdates the zod version in the test scaffold install command to ^4.0.0 and adds an explicit any type annotation for validatedData in a Node policy handler. No control flow or runtime behavior changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
LICENSE (1)
3-3: Consider a year range to avoid annual editsUsing a range reduces churn without changing legal meaning (if acceptable to your policy).
Apply:
-Copyright (c) 2025 ZenStack +Copyright (c) 2022-2025 ZenStackpackages/LICENSE (1)
3-3: Mirror the root LICENSE suggestion: use a year rangeKeeps the file from needing yearly bumps.
Apply:
-Copyright (c) 2025 ZenStack +Copyright (c) 2022-2025 ZenStack
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
LICENSE(1 hunks)packages/LICENSE(1 hunks)script/test-scaffold.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: build-test (20.x)
- GitHub Check: OSSAR-Scan
- GitHub Check: build-test (20.x)
- GitHub Check: dependency-review
- GitHub Check: build-test (20.x)
🔇 Additional comments (1)
script/test-scaffold.ts (1)
23-23: Pin Zod v4 to 4.0.x and verify scaffold’s Node/ESM configuration
- Change
zod@^4.0.0tozod@4.0.xin script/test-scaffold.ts:23 to prevent minor-version drift in CI.- Ensure your scaffold (generated via
npm init -y) and any CI workflows use Node 16+ and moduleResolution settings that support Zod v4’s exports/subpath imports.
No description provided.