Skip to content

Conversation

@ymc9
Copy link
Member

@ymc9 ymc9 commented Sep 7, 2025

No description provided.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 7, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml, !**/*.yaml

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

Updates the zod version in the test scaffold install command to ^4.0.0 and adds an explicit any type annotation for validatedData in a Node policy handler. No control flow or runtime behavior changes.

Changes

Cohort / File(s) Summary
Scaffold dependency spec
script/test-scaffold.ts
Bumps zod dependency in the npm install command from ^3.25.0 to ^4.0.0.
Type annotation adjustment
packages/runtime/src/enhancements/node/policy/handler.ts
Adds explicit any type annotation to validatedData in the update input schema validation path; TypeScript-only change.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/test-zod-4

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
LICENSE (1)

3-3: Consider a year range to avoid annual edits

Using a range reduces churn without changing legal meaning (if acceptable to your policy).

Apply:

-Copyright (c) 2025 ZenStack
+Copyright (c) 2022-2025 ZenStack
packages/LICENSE (1)

3-3: Mirror the root LICENSE suggestion: use a year range

Keeps the file from needing yearly bumps.

Apply:

-Copyright (c) 2025 ZenStack
+Copyright (c) 2022-2025 ZenStack
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e798397 and f6bb6fd.

📒 Files selected for processing (3)
  • LICENSE (1 hunks)
  • packages/LICENSE (1 hunks)
  • script/test-scaffold.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: build-test (20.x)
  • GitHub Check: OSSAR-Scan
  • GitHub Check: build-test (20.x)
  • GitHub Check: dependency-review
  • GitHub Check: build-test (20.x)
🔇 Additional comments (1)
script/test-scaffold.ts (1)

23-23: Pin Zod v4 to 4.0.x and verify scaffold’s Node/ESM configuration

  • Change zod@^4.0.0 to zod@4.0.x in script/test-scaffold.ts:23 to prevent minor-version drift in CI.
  • Ensure your scaffold (generated via npm init -y) and any CI workflows use Node 16+ and moduleResolution settings that support Zod v4’s exports/subpath imports.

@ymc9 ymc9 closed this Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants