-
-
Notifications
You must be signed in to change notification settings - Fork 126
Rest api sparse fieldsets #2251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughAdds sparse fieldset (partial-field) selection to REST read operations. Implements buildPartialSelect, integrates it into single, related, relationship, and collection reads, merges with includes, validates duplicated fields parameters, and updates serialization for to-one/to-many relations. Adds comprehensive tests covering fields, includes, filtering, sorting, and pagination. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant C as Client
participant H as REST Handler
participant PS as buildPartialSelect
participant PR as Prisma
participant S as Serializer
C->>H: GET /:type[?fields[type]=...&include=...]
H->>PS: compute partial select for type and included types
alt duplicated fields parameter
PS-->>H: Error { code: duplicatedFieldsParameter }
H-->>C: 400 Bad Request
else valid
PS-->>H: select maps (type -> select)
H->>H: merge select with include for relations
H->>PR: findUnique/findMany(args.select/include)
PR-->>H: data
H->>S: serialize with partial selects (to-one/to-many)
S-->>H: JSON:API payload
H-->>C: 200 OK
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Implements sparse fieldsets as defined by https://jsonapi.org/format/#fetching-sparse-fieldsets