Skip to content

Conversation

@ymc9
Copy link
Member

@ymc9 ymc9 commented Sep 29, 2025

No description provided.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 29, 2025

📝 Walkthrough

Walkthrough

Adds dotenv-based environment loading at the start of the build script, loading ./.env.local then ./.env, and removes an unused path require. No exported/public API changes.

Changes

Cohort / File(s) Summary
Build script env loading
packages/schema/build/bundle.js
Added dotenv.config for ./.env.local and ./.env; removed const path = require('path');; environment variables now loaded before build logic executes.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant Dev as Developer
    participant Script as build/bundle.js
    participant Dotenv as dotenv
    Note over Script: Startup
    Dev->>Script: run script
    Script->>Dotenv: config({ path: "./.env.local" })
    Dotenv-->>Script: load vars (if present)
    Script->>Dotenv: config({ path: "./.env" })
    Dotenv-->>Script: load vars (if present)
    Note over Script: Proceed with build using process.env
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning No pull request description is provided, so there is no contextual or explanatory information related to the changeset, leaving reviewers without guidance on the purpose or details of the update. Please add a pull request description that outlines the purpose of replacing the explicit path require with dotenv configuration, specifying which environment files are loaded and why, to give reviewers clear context.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title clearly and concisely describes the main change of integrating dotenv into the bundler script, making it easy to understand the primary intent at a glance.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/use-dotenv-in-bundle

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ada3469 and d49ac7a.

📒 Files selected for processing (1)
  • packages/schema/build/bundle.js (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: build-test (20.x)
  • GitHub Check: dependency-review
  • GitHub Check: OSSAR-Scan
  • GitHub Check: build-test (20.x)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: build-test (20.x)

@ymc9 ymc9 enabled auto-merge (squash) September 29, 2025 03:06
@ymc9 ymc9 disabled auto-merge September 29, 2025 03:25
@ymc9 ymc9 merged commit edbceb5 into dev Sep 29, 2025
12 checks passed
@ymc9 ymc9 deleted the chore/use-dotenv-in-bundle branch September 29, 2025 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant