Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: keep releases lean #27

Merged
merged 1 commit into from
Jul 19, 2024
Merged

chore: keep releases lean #27

merged 1 commit into from
Jul 19, 2024

Conversation

raphaelstolt
Copy link
Contributor

@nikophil nikophil changed the title chore: keep releases lean chore: keep releases clean Jul 19, 2024
@nikophil nikophil changed the title chore: keep releases clean chore: keep releases lean Jul 19, 2024
nikophil
nikophil requested changes Jul 19, 2024
View reviewed changes
Copy link
Member

@nikophil nikophil left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this!

imo, LICENSE, README and CHANGELOG should be part of the release (same for console-test)

that's what is done eg in doctrine or symfony packages

nikophil
nikophil approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@nikophil nikophil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@nikophil nikophil merged commit 770d579 into zenstruck:1.x Jul 19, 2024
10 checks passed
@raphaelstolt raphaelstolt deleted the lean-releases branch July 19, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikophil nikophil nikophil approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raphaelstolt @nikophil