[2.x] feat: remove behat/mink requirement and add new selector API
#125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Apr 26, 2023
|
I just saw this issue... sorry for the late reply 😅 It's been a while I have not worked on an "html" app (only json apis, or full messenger apps). Sorry I can't help |
|
@kbond I currently don't have time, but you have access to one or two of my projects, so feel free to run them against this branch |
|
Thanks Oskar, I'll try it out on your projects when I pick this PR up again. |
kbond
force-pushed
the
interactive-dom
branch
from
c77fd34 to
7bd76aa
Compare
kbond
changed the title
behat/mink requirement and add new selector APIbehat/mink requirement and add new selector API
kbond
force-pushed
the
interactive-dom
branch
from
7bd76aa to
a654d50
Compare
kbond
force-pushed
the
interactive-dom
branch
from
a654d50 to
0336eec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15, Fixes #12. Fixes #37. Fixes #77.
Replacing mink with my own dom system allowed me to create a new selector api (#77). The plan is to extract the dom stuff into a new
zenstruck/dompackage so it can be utilized by this package + others that need to make dom assertions./cc @weaverryan, @jwage, @nikophil, @OskarStark, when/if time permits, I'd appreciate if you could test this in any html-heavy apps you have that use browser. I found and fixed (and added tests) for several edge cases when testing this in my app.
TODO:
zenstruck/dom