fix: Handle command defined with AsCommand php attribute #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cryde
commented
Dec 24, 2024
src/TestCommand.php
Outdated
| @@ -56,6 +57,9 @@ public static function for(Command $command): self | |||
| public static function from(Application $application, string $cli): self | |||
| { | |||
| foreach ($application->all() as $commandObject) { | |||
| if ($commandObject instanceof LazyCommand) { | |||
There was a problem hiding this comment.
I'm not really sure if this is the right way to do it.
Cryde
commented
Dec 24, 2024
| name: 'fixture:command', | ||
| description: 'zenstruck/console-test command for tests' | ||
| )] | ||
| final class FixtureAttributeCommand extends Command |
There was a problem hiding this comment.
I have copy past your other FixtureCommand but without cleaning it
Maybe tests should be duplicated for this case (with #[AsCommand] attribute) ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the
#[AsCommand]attribute make commands lazyWhen using this phpunit helper lib I am unable to launch command from tests