-
-
Notifications
You must be signed in to change notification settings - Fork 107
fix: autorefresh should work after kernel shutdown #1011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: autorefresh should work after kernel shutdown #1011
Conversation
| /** @param \Closure():self|self $configuration */ | ||
| public static function boot(\Closure|self $configuration): void | ||
| { | ||
| PersistedObjectsTracker::reset(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
culprit was here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello !
Looks like this change has side effect :
class FooTest extends WebTestCase
{
use Factories;
public function testFoo(): void
{
FooFactory::create();
}
}gives us
Error: Typed static property Zenstruck\Foundry\Persistence\Proxy\PersistedObjectsTracker::$buffer must not be accessed before initialization
/var/www/project/vendor/zenstruck/foundry/src/Persistence/Proxy/PersistedObjectsTracker.php:53
/var/www/project/vendor/zenstruck/foundry/src/Persistence/PersistenceManager.php:89
/var/www/project/vendor/zenstruck/foundry/src/Persistence/PersistentObjectFactory.php:266
/var/www/project/tests/Functional/FooTest.php:7
Is there anything special to do to initialize foundry with this new version ?
c1b9ccb to
e666d2b
Compare
|
Hey! I'm sorry for posting here, but it looks like this releases broke the Symfony UX tests-suite (https://github.com/symfony/ux/actions/runs/18675203003/job/53243634658?pr=3145), the test https://github.com/symfony/ux/blob/cd4dbe384bb4338a6ff9f384fdc6df7543e53db5/src/LiveComponent/tests/Functional/EventListener/LiveComponentSubscriberTest.php#L46-L73 is not passing anymore: Do you know what can happens? |
|
hi @Kocal I won't be able to fix this today 😬 Please add a conflict on this version in you repo, I'll fix this tomorrow |
|
No problem, at least you know. |
fixes #1009