Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Added some docs to clarify default attributes and fixed some syntax issues #765

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

nikophil
Copy link
Member

@nikophil nikophil commented Dec 18, 2024

here is a proposal based on @javiereguiluz 's PR - I've separated the special method instantiateWith(callable(...)), so that it's clear that it works in a different way than the others

…ntax issues
@nikophil nikophil force-pushed the tweak_docs branch 2 times, most recently from 4f0e493 to d4182bc Compare December 18, 2024 16:26
@nikophil nikophil changed the title tweak docs [Doc] Added some docs to clarify default attributes and fixed some syntax issues Dec 18, 2024
@nikophil nikophil requested a review from kbond December 18, 2024 16:28
@nikophil nikophil marked this pull request as ready for review December 18, 2024 16:29
@nikophil nikophil merged commit e8f9a92 into zenstruck:2.x Dec 20, 2024
71 checks passed
@nikophil nikophil deleted the tweak_docs branch December 20, 2024 12:59
javiereguiluz added a commit to javiereguiluz/foundry that referenced this pull request Dec 20, 2024
* upstream/2.x:
  docs: clarify default attributes and fixed some syntax issues (zenstruck#765)
  tests: validate PSR-4 in CI (zenstruck#762)
  [Docs fix] Just spelling in docs (zenstruck#761)
  [Docs fix] Proxy::_save() instead of Proxy::save() (zenstruck#760)
  [Docs fix] Factory::_real() instead Factory::object() (zenstruck#759)
@javiereguiluz
Copy link
Contributor

I couldn't review this earlier, but I just did and your changes are very nice. Nicolas, thanks a lot for taking care of this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants