feat!: store wait_time/handle_time in milliseconds

[kbond]

Ref: #105 (comment)

[kbond]

@bendavies, @bobvandevijver, mind giving this a review? ❤️

[kbond]

Should I be using bigint? If I'm calculating correct, we can only store ~24 days in milliseconds with a signed int with MySQL.

(pretty sure the answer is yes so I updated to use bigint)

[bobvandevijver]

bigint is the way to go indeed, lgtm 👍🏻

[bendavies]

LGTM, but it's still displaying the times in seconds in the UI?

[bendavies]

looks like you can use DateTimeImmutable::format('Uv') to get millseconds, instead of messing with format('U.u') * 1000 ?

https://3v4l.org/ME1X7

[kbond]

looks like you can use DateTimeImmutable::format('Uv') to get millseconds

Excellent find, thanks!

LGTM, but it's still displaying the times in seconds in the UI?

The views show them as human readable durations (ie "4 seconds") but if you hover over, it shows the partial seconds (ie 4.032s).

I decided to have the objects that return durations (ie ProcessedMessage::timeToHandle()) return seconds as a float but what do you think? Should they return the milliseconds as an int then convert to seconds in the UI?

[bendavies]

Personally, as most of my messages take less than one second, I would prefer to see xxx ms rather than 0s and have to hover.

[bendavies]

We could display 0.xxx if less than 1 second?

[kbond]

Ok, I'll see what I can do.

[bobvandevijver]

Maybe displaying ms if smaller than 5 or 10 seconds, and using s for everything above is nice?

[kbond]

Thanks @bendavies! Fixed in #128.