Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set default $limit to 500 on transportInfo #40

Conversation

golliholzland
Copy link
Contributor

This work around for large data and in order to keep the dashboard running,

@kbond
Copy link
Member

kbond commented Oct 31, 2023

Thanks for working on this.

  • Do you think 500 is too much? What about just 100?
  • I'd like this limit to be done in the view/controller rather than in TransportInfo::list()
  • I'd like to show a warning message if the actual count of the transport exceeds this artificial limit (explaining the problem)

(I can also finish this PR up when time permits)

@golliholzland
Copy link
Contributor Author

@kbond it depends on the message size, but yes if this could be configurable it would be better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants