-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add check for LiipMonitoring-Bundle (WIP) #61
base: 1.x
Are you sure you want to change the base?
Conversation
dcb2c49
to
3e5afd3
Compare
Ah yes, this is a bit tricky and we'll have to make a decision on "where the config should live". Option 1 - Config lives in liip_monitor: For this, we'd need a way to bundles (like this one), to announce to LiipMonitorBundle that it has a configurable check. I do something similar in ZenstruckBackupBundle but it isn't extensible (the extra config options are hard-coded). What we need is sort of a pre-compile container that has the liip_monitor check config factories tagged. I'm not sure this is possible - we might have to use composer.json config - in LiipMonitorBundle's extension, look for all installed packages that have a specific key in their composer.json. This will probably get complex... Option 2 - Config lives in this bundle: For this, we'd add a liip_monitor key to this bundle's config that's only available when LiipMonitorBundle is enabled. You can then have Option 1 seems ideal but 2 seems easiest. |
Co-authored-by: Kevin Bond <kevinbond@gmail.com>
Thanks for the info. |
If someone is interested in a quick solution in userland code.
|
i try to add checks for LiipMonitoring-Bundle
#11
But i am a bit stucked here.
I followed the example from here https://github.com/kbond/LiipMonitorBundle/tree/feat/ohdear#custom-checks
and took this Check as example https://github.com/kbond/LiipMonitorBundle/blob/feat/ohdear/src/Check/Symfony/SymfonyVersionCheck.php
I thought i could activated it like this.
And see it with
php bin/console monitor:list
But i will get an error, that
symfony_worker_running
is not registered unterchecks
.@kbond Maybe you can give me a little push to the right direction?