Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allows to use options configuration #80

Merged
merged 5 commits into from
Apr 18, 2024

Conversation

aegypius
Copy link
Contributor

Fixes #79

@nikophil
Copy link
Member

@kbond don't you think we could make methods TestTransport::isIntercepting(), isCatchingExceptions() and so on public? this way we could test this PR

@kbond
Copy link
Member

kbond commented Apr 16, 2024

don't you think we could make methods TestTransport::isIntercepting(), isCatchingExceptions() and so on public?

I don't have a problem with this.

@aegypius aegypius force-pushed the allows-options-based-configuration branch from fa5bcc1 to eae3025 Compare April 16, 2024 15:14
Copy link
Member

@kbond kbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice @aegypius!

@kbond kbond requested a review from nikophil April 16, 2024 15:26
Copy link
Member

@kbond kbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aegypius, could you fix the deprecations in TestTransportFactoryTest?

@aegypius
Copy link
Contributor Author

@aegypius, could you fix the deprecations in TestTransportFactoryTest?

Working on it

@aegypius
Copy link
Contributor Author

@kbond
Copy link
Member

kbond commented Apr 16, 2024

Should not self::$supportDelayStamp be resetted too

I'm thinking yes but @nikophil, can you confirm?

@nikophil
Copy link
Member

nikophil commented Apr 17, 2024

not sure this is needed:

TestTransport::resetAll() is called in a #[After] hook in order to reset everything in TestTransport that could have changed in the test execution: including all different states ($queued, $rejected...) but also $intercept and $catchExceptions which can be modified by methods catchExceptions()/throwExceptions() and unblock()/intercept()

Since we're not allowing $supportDelayStamp to be modified (and we should not do this: this behavior will be the default one in a further major version, and could not be disabled), it is not needed to reset it

@kbond
Copy link
Member

kbond commented Apr 18, 2024

not sure this is needed:

Ok, let's leave as is for now.

@kbond kbond merged commit 7164fce into zenstruck:1.x Apr 18, 2024
17 checks passed
@kbond
Copy link
Member

kbond commented Apr 18, 2024

Thank you @aegypius!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

transport options are not processed when configure in the options
3 participants