-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allows to use options configuration #80
fix: allows to use options configuration #80
Conversation
@kbond don't you think we could make methods |
I don't have a problem with this. |
fa5bcc1
to
eae3025
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really nice @aegypius!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aegypius, could you fix the deprecations in TestTransportFactoryTest
?
Working on it |
Should not |
I'm thinking yes but @nikophil, can you confirm? |
not sure this is needed:
Since we're not allowing |
Ok, let's leave as is for now. |
Thank you @aegypius! |
Fixes #79