Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade CI matrix #92

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

nikophil
Copy link
Member

No description provided.

@HypeMC
Copy link
Contributor

HypeMC commented Sep 26, 2024

@nikophil This one was a real pain to debug. The problem is related to this issue. The default jitter is 0.1, so if the delay time is 1 second, the test will pass or fail depending on whether the final delay time is over or under 1000ms. Hope this helps.

@nikophil nikophil force-pushed the chore/update-ci-matrix branch 2 times, most recently from cc8037f to db78faf Compare September 26, 2024 16:15
@HypeMC
Copy link
Contributor

HypeMC commented Sep 26, 2024

@nikophil I think setting the jitter to zero would be the most logical solution:

async4:
    dsn: test://?disable_retries=false&support_delay_stamp=true
    retry_strategy:
        jitter: 0

However, since previous versions of Symfony don't have this option, just setting it in the yaml won't be enough as it'll break on lower versions. Maybe a compiler pass that'll set the jitter to zero if it's Sf 7.1+?

Or maybe switch to php files and add some conditions?

@nikophil
Copy link
Member Author

This one was a real pain to debug

no doubt about this!

Hope this helps

super helpful, thanks! And also, I found another problem, we were rounding to seconds the delay, so any delay of less than 1 second was basically not delayed at all.

I think setting the jitter to zero would be the most logical solution

yeah, I was actually working on something else: I'll declare a strategy service in Kernel.php, that will do the trick

@nikophil nikophil force-pushed the chore/update-ci-matrix branch from db78faf to 56998fa Compare September 26, 2024 16:38
@nikophil nikophil force-pushed the chore/update-ci-matrix branch from 56998fa to ae2a41a Compare September 26, 2024 16:39
@nikophil nikophil merged commit 36329a1 into zenstruck:1.x Sep 26, 2024
14 checks passed
@nikophil nikophil deleted the chore/update-ci-matrix branch September 26, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants