Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

microblaze: apply gdb patches from meta-xilinx repository #11

Conversation

alpsayin
Copy link

@alpsayin alpsayin commented Oct 1, 2023

microblaze: apply gdb patches from meta-xilinx repository

This patchset fixes many known issues on gnu-toolchain for microblaze.
But mainly the atomic-cas and binutils incorrect relocation issues.

Patches obtained from https://github.com/xilinx/meta-xilinx/ repository,
from meta-microblaze/recipes-devtools/gdb path.

Introduction of Microblaze64 didn't break gdb build, so Ive decided to let it be.

@alpsayin alpsayin force-pushed the zephyr-gdb-12.1-microblaze-recipes-27082023 branch from f5e57a5 to b594ebe Compare October 2, 2023 21:20
@alpsayin alpsayin changed the title Zephyr gdb 12 1 microblaze recipes 28082023 microblaze: apply gdb patches from meta-xilinx repository Oct 2, 2023
@alpsayin alpsayin force-pushed the zephyr-gdb-12.1-microblaze-recipes-27082023 branch from b594ebe to 18d1778 Compare October 2, 2023 22:16
@alpsayin alpsayin marked this pull request as ready for review October 2, 2023 22:22
Makefile.def Outdated Show resolved Hide resolved
Makefile.in Outdated Show resolved Hide resolved
sim/common/Make-common.in Outdated Show resolved Hide resolved
@alpsayin alpsayin force-pushed the zephyr-gdb-12.1-microblaze-recipes-27082023 branch from 18d1778 to c8e8e46 Compare December 2, 2023 13:21
@alpsayin
Copy link
Author

alpsayin commented Dec 2, 2023

@stephanosio resolved the marked issues and some more that I noticed irrelevant to microblaze. Something bad happens during startup though. I'm inspecting this one further.
UPDATE: it's the damn microblaze64 or linux-microblaze ports again. I've filtered them out and kept one important patch that resolves a really annoying issue.

@alpsayin alpsayin force-pushed the zephyr-gdb-12.1-microblaze-recipes-27082023 branch 2 times, most recently from d0b3a0f to 8fed488 Compare December 2, 2023 14:24
This patchset fixes many known issues on gnu-toolchain for microblaze.
But mainly the atomic-cas and binutils incorrect relocation issues. For gdb
this patchset resolves the segfault caused by inline-sniffer.

Patches obtained from https://github.com/xilinx/meta-xilinx/ repository,
from meta-microblaze/recipes-devtools/gdb/gdb path.
I've filtered out microblaze64 and microblaze-linux patches because they
cause microblaze-gdb to segfault at startup and more importantly,
unnecessary for Zephyr. Below is a list of patches applied and squashed:

0008-Patch-MicroBlaze.patch

Signed-off-by: Alp Sayin <alpsayin@gmail.com>
@alpsayin alpsayin force-pushed the zephyr-gdb-12.1-microblaze-recipes-27082023 branch from 8fed488 to ffe6d2f Compare December 2, 2023 14:25
@alpsayin
Copy link
Author

alpsayin commented Dec 2, 2023

@stephanosio It's the damn microblaze64 or linux-microblaze ports again. I've filtered them out and kept one important patch that resolves a really annoying issue. Ready for re-review. Considering that only a single patch is left I'm half-expecting that I'll be asked to apply the original commit with its author,date and message but with a bit of Zephyr commit guideline application microblaze: foo bar etc. ... ?

@stephanosio
Copy link
Member

@stephanosio It's the damn microblaze64 or linux-microblaze ports again. I've filtered them out and kept one important patch that resolves a really annoying issue. Ready for re-review. Considering that only a single patch is left I'm half-expecting that I'll be asked to apply the original commit with its author,date and message but with a bit of Zephyr commit guideline application microblaze: foo bar etc. ... ?

Given that the original patch is fairly void of any useful information, the current commit looks good.

@stephanosio stephanosio merged commit 66646cf into zephyrproject-rtos:zephyr-gdb-12.1 Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants