Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nrfx_config_nr9160: Add missing mappings of peripheral base addresses #3

Conversation

anangl
Copy link
Member

@anangl anangl commented Sep 5, 2019

For quite a few peripherals that are currently supported by nrfx HALs
or drivers there are no definitions of corresponding CMSIS-Core
peripheral accessing symbols that would provide their base addresses
in the proper domain (secure or non-secure), accordingly to the build
target. This commits adds these missing definitions.

For quite a few peripherals that are currently supported by nrfx HALs
or drivers there are no definitions of corresponding CMSIS-Core
peripheral accessing symbols that would provide their base addresses
in the proper domain (secure or non-secure), accordingly to the build
target. This commits adds these missing definitions.

Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
Copy link
Member

@ioannisg ioannisg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me

@ioannisg ioannisg requested a review from carlescufi September 5, 2019 15:05
@ioannisg ioannisg added the enhancement New feature or request label Sep 5, 2019
Copy link
Collaborator

@kl-cruz kl-cruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@ioannisg ioannisg merged commit 2468dbd into zephyrproject-rtos:master Sep 9, 2019
@anangl anangl deleted the add_missing_nrf9160_peripheral_symbols branch September 9, 2019 08:18
pkwiek added a commit to pkwiek/hal_nordic that referenced this pull request Dec 15, 2020
Fix zephyrproject-rtos#1:
Transmission failure would cause to leave an allocated buffer resulting
in a serialization failure leading to an assert, which was seen as a
timeout error on APP core side.

Fix zephyrproject-rtos#2:
It is possible for nrf_802154_spinel_send function to be preempted
resulting in the static frame buffer being reused. The buffer size was
reduced accordingly to 802.15.4 frame size and possible additional data.

Fix zephyrproject-rtos#3:
Radio driver's API call using serialization can be preempted after
issuing a serialized call request to NET core, but before preparing
the notifier for an awaited property. This results in receiving a
property that no one waits for and dropping the property as an unwanted.
In current implementation the awaited property is prepared during the
notifier lock.

Re-fix zephyrproject-rtos#4:
The issue which manifests itself in disabled NVIC interrupts in SED
roles.

Signed-off-by: Pawel Kwiek <pawel.kwiek@nordicsemi.no>
rlubos pushed a commit that referenced this pull request Dec 16, 2020
Fix #1:
Transmission failure would cause to leave an allocated buffer resulting
in a serialization failure leading to an assert, which was seen as a
timeout error on APP core side.

Fix #2:
It is possible for nrf_802154_spinel_send function to be preempted
resulting in the static frame buffer being reused. The buffer size was
reduced accordingly to 802.15.4 frame size and possible additional data.

Fix #3:
Radio driver's API call using serialization can be preempted after
issuing a serialized call request to NET core, but before preparing
the notifier for an awaited property. This results in receiving a
property that no one waits for and dropping the property as an unwanted.
In current implementation the awaited property is prepared during the
notifier lock.

Re-fix #4:
The issue which manifests itself in disabled NVIC interrupts in SED
roles.

Signed-off-by: Pawel Kwiek <pawel.kwiek@nordicsemi.no>
adamkondraciuk pushed a commit to adamkondraciuk/hal_nordic that referenced this pull request Dec 18, 2020
…ure/NRFX-360-integrate-nrfx to haltium-dev

* commit '3fa363cccf36ed53392b3c9d329e6cf6a2513756':
  NRFX-360: nrfx: integrate 3.0.0-alpha-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants