Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mcux-sdk: Update to SDK 2.15.000 #329

Merged
merged 4 commits into from
Mar 5, 2024
Merged

mcux-sdk: Update to SDK 2.15.000 #329

merged 4 commits into from
Mar 5, 2024

Conversation

dleach02
Copy link
Member

Updating NXP HAL to SDK 2.15.000

@zephyrbot zephyrbot mentioned this pull request Jan 30, 2024
Merged
gmarull
gmarull previously requested changes Jan 31, 2024
View reviewed changes
Copy link
Member

@gmarull gmarull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds yet more binary blobs (*.FLM), which makes things worse than they already are. Please, remove all the unnecessary stuff (which is a lot). This repo is cloned by everybody following the GSG, and so should be kept in decent shape.

@dleach02
Copy link
Member Author

dleach02 commented Feb 1, 2024

This PR adds yet more binary blobs (*.FLM), which makes things worse than they already are. Please, remove all the unnecessary stuff (which is a lot). This repo is cloned by everybody following the GSG, and so should be kept in decent shape.

The flm files were an oversite and will be removed.

@dleach02 dleach02 force-pushed the mcux_2.15.000_RW61x branch 2 times, most recently from 746cbd7 to 6379eef Compare February 6, 2024 18:56
@dleach02 dleach02 requested review from gmarull, brycewilkins, danieldegrasse and decsny and removed request for brycewilkins February 22, 2024 01:48
@dleach02
Copy link
Member Author

@gmarull, I've removed the binary files and additional items (hard to review though based on the number of files). Good catch.

brycewilkins
brycewilkins reviewed Feb 22, 2024
View reviewed changes
Copy link

@brycewilkins brycewilkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of observations from the README.

  • A more recent commit from MCUX SDK would be good to grab the LTO fix.

mcux/README Outdated Show resolved Hide resolved
mcux/README Outdated Show resolved Hide resolved
mcux/README Outdated Show resolved Hide resolved
@dleach02
Copy link
Member Author

@brycewilkins, thank you for the review and comments. I will be updating this PR soon with the the updates on mcux-sdk after a quick sync with the SDK team.

@dleach02 dleach02 force-pushed the mcux_2.15.000_RW61x branch from 6379eef to 3c9dbd0 Compare February 22, 2024 23:31
@mmahadevan108 mmahadevan108 force-pushed the mcux_2.15.000_RW61x branch 5 times, most recently from b738a6e to 374e772 Compare February 28, 2024 14:35
@mmahadevan108
Copy link
Collaborator

This PR adds yet more binary blobs (*.FLM), which makes things worse than they already are. Please, remove all the unnecessary stuff (which is a lot). This repo is cloned by everybody following the GSG, and so should be kept in decent shape.

@gmarull, the PR has been updated, kindly re-review.

@dleach02 dleach02 self-assigned this Feb 29, 2024
@hakehuang hakehuang requested review from hakehuang and removed request for brycewilkins March 1, 2024 03:13
hakehuang
hakehuang approved these changes Mar 1, 2024
View reviewed changes
Copy link
Collaborator

@hakehuang hakehuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

full build on NXP platforms OK. and board testing for imxrt/kinetis/lpc are OK

brycewilkins
brycewilkins approved these changes Mar 1, 2024
View reviewed changes
Copy link

@brycewilkins brycewilkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have this updated to the latest SDK and remove a lot of items from the patch list!

Also excellent idea to list the SHAs in the README.

@gmarull
Copy link
Member

gmarull commented Mar 1, 2024

This PR adds yet more binary blobs (*.FLM), which makes things worse than they already are. Please, remove all the unnecessary stuff (which is a lot). This repo is cloned by everybody following the GSG, and so should be kept in decent shape.

@gmarull, the PR has been updated, kindly re-review.

I still see many files that should likely not be there:

image

Or... there's even a USB stack https://github.com/nxp-zephyr/hal_nxp/tree/mcux_2.15.000_RW61x/mcux/middleware/mcux-sdk-middleware-usb ? @jfischer-no

@mmahadevan108
Copy link
Collaborator

mmahadevan108 commented Mar 1, 2024 •
edited
Loading

Thanks for catching this. I had missed deleting these .ldt files. We are working with the internal team to remove these files in the main mcux-sdk repo.
https://github.com/nxp-zephyr/hal_nxp/tree/mcux_2.15.000_RW61x/mcux/middleware/mcux-sdk-middleware-usb is required for https://github.com/zephyrproject-rtos/zephyr/blob/main/drivers/usb/device/usb_dc_mcux.c USB driver.

@dleach02
Copy link
Member Author

dleach02 commented Mar 3, 2024 •
edited
Loading

@mmahadevan108, can you rebase this with the current since we just merged the HWMv2 changes. Want to make sure things are still okay from a CI perspective.

@mmahadevan108
Copy link
Collaborator

@gmarull, can you take a look.

@mmahadevan108
Copy link
Collaborator

mmahadevan108 commented Mar 4, 2024 •
edited
Loading

@mmahadevan108, can you rebase this with the current since we just merged the HWMv2 changes. Want to make sure things are still okay from a CI perspective.

Rebased, @hakehuang . Could you do a test one more time to see if all looks fine with update to HWV2 and SDK 2.15 update.

@dbaluta dbaluta mentioned this pull request Mar 5, 2024
Closed
@gmarull gmarull dismissed their stale review March 5, 2024 12:22

looks like many files have been deleted, a new pass can be done if more are detected

This was referenced Mar 5, 2024
Closed
Closed
@dbaluta dbaluta mentioned this pull request Mar 5, 2024
Merged
5 tasks
dleach02 added 4 commits March 5, 2024 10:11
@dleach02 @mmahadevan108
mcux-sdk: Update to SDK 2.15.000
4341458 
Update mcux-sdk to 2.15.000 + RW61x

Signed-off-by: David Leach <david.leach@nxp.com>
@dleach02 @mmahadevan108
mcux-sdk: drivers: Add local changes to the CAAM driver
c1d5a80 
Move used job descriptors in the CAAM driver from the stack to
noncacheable section.

This change has not been accepted by the SDK team and needs to
be maintained here.

Signed-off-by: David Leach <david.leach@nxp.com>
@dleach02 @mmahadevan108
mcux-sdk-middleware-usb: remove documents
2529683 
Remove document PDF files.

Signed-off-by: David Leach <david.leach@nxp.com>
@dleach02 @mmahadevan108
README: Update patch list
a92c1d2 
Number of items are no longer needed

Signed-off-by: David Leach <david.leach@nxp.com>
@danieldegrasse danieldegrasse merged commit c5a5636 into zephyrproject-rtos:master Mar 5, 2024
@mmahadevan108 mmahadevan108 deleted the mcux_2.15.000_RW61x branch March 8, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldegrasse danieldegrasse danieldegrasse approved these changes

@brycewilkins brycewilkins brycewilkins approved these changes

@hakehuang hakehuang hakehuang approved these changes

@mmahadevan108 mmahadevan108 Awaiting requested review from mmahadevan108

@gmarull gmarull Awaiting requested review from gmarull

@decsny decsny Awaiting requested review from decsny

Assignees

@dleach02 dleach02

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dleach02 @mmahadevan108 @gmarull @hakehuang @brycewilkins @danieldegrasse