add RT700 NPI files firstly #444

lucien-nxp · 2024-10-03T07:02:15Z

add RT700 sdk files
add RT700 pin header files

iuliana-prodan · 2024-10-14T14:28:32Z

mcux/mcux-sdk/devices/MIMXRT798S/drivers/Kconfig

+# driver_dsp
+config MCUX_USE_driver_dsp
+    bool "dsp Driver"
+    select MCUX_USE_driver_power


Why do we include the fsl_power for the DSP?
The driver has a lot of ARM specific registers or functions.
When compiling for HiFi4 I get:

In file included from /opt/samba/nxa06898/zephyrproject/modules/hal/nxp/mcux/mcux-sdk/devices/MIMXRT798S/drivers/fsl_power.c:8: /opt/samba/nxa06898/zephyrproject/modules/hal/nxp/mcux/mcux-sdk/devices/MIMXRT798S/drivers/fsl_power.h: In function 'POWER_EnableDeepSleep': /opt/samba/nxa06898/zephyrproject/modules/hal/nxp/mcux/mcux-sdk/devices/MIMXRT798S/drivers/fsl_power.h:735:5: error: 'SCB' undeclared (first use in this function) 735 | SCB->SCR |= SCB_SCR_SLEEPDEEP_Msk; | ^~~ /opt/samba/nxa06898/zephyrproject/modules/hal/nxp/mcux/mcux-sdk/devices/MIMXRT798S/drivers/fsl_power.h:735:5: note: each undeclared identifier is reported only once for each function it appears in /opt/samba/nxa06898/zephyrproject/modules/hal/nxp/mcux/mcux-sdk/devices/MIMXRT798S/drivers/fsl_power.h:735:17: error: 'SCB_SCR_SLEEPDEEP_Msk' undeclared (first use in this function) 735 | SCB->SCR |= SCB_SCR_SLEEPDEEP_Msk; | ^~~~~~~~~~~~~~~~~~~~~ /opt/samba/nxa06898/zephyrproject/modules/hal/nxp/mcux/mcux-sdk/devices/MIMXRT798S/drivers/fsl_power.h: In function 'POWER_DisableDeepSleep': /opt/samba/nxa06898/zephyrproject/modules/hal/nxp/mcux/mcux-sdk/devices/MIMXRT798S/drivers/fsl_power.h:743:5: error: 'SCB' undeclared (first use in this function) 743 | SCB->SCR &= ~SCB_SCR_SLEEPDEEP_Msk; | ^~~ /opt/samba/nxa06898/zephyrproject/modules/hal/nxp/mcux/mcux-sdk/devices/MIMXRT798S/drivers/fsl_power.h:743:18: error: 'SCB_SCR_SLEEPDEEP_Msk' undeclared (first use in this function) 743 | SCB->SCR &= ~SCB_SCR_SLEEPDEEP_Msk; | ^~~~~~~~~~~~~~~~~~~~~ /opt/samba/nxa06898/zephyrproject/modules/hal/nxp/mcux/mcux-sdk/devices/MIMXRT798S/drivers/fsl_power.c: In function 'POWER_SetPmicMode': /opt/samba/nxa06898/zephyrproject/modules/hal/nxp/mcux/mcux-sdk/devices/MIMXRT798S/drivers/fsl_power.c:226:5: warning: implicit declaration of function '__disable_irq'; did you mean 'DisableIRQ'? [-Wimplicit-function-declaration] 226 | __disable_irq(); | ^~~~~~~~~~~~~ | DisableIRQ /opt/samba/nxa06898/zephyrproject/modules/hal/nxp/mcux/mcux-sdk/devices/MIMXRT798S/drivers/fsl_power.c:231:5: warning: implicit declaration of function '__enable_irq' [-Wimplicit-function-declaration] 231 | __enable_irq(); | ^~~~~~~~~~~~ /opt/samba/nxa06898/zephyrproject/modules/hal/nxp/mcux/mcux-sdk/devices/MIMXRT798S/drivers/fsl_power.c: In function 'POWER_EnterSleep': /opt/samba/nxa06898/zephyrproject/modules/hal/nxp/mcux/mcux-sdk/devices/MIMXRT798S/drivers/fsl_power.c:385:12: warning: implicit declaration of function '__get_PRIMASK' [-Wimplicit-function-declaration] 385 | pmsk = __get_PRIMASK(); | ^~~~~~~~~~~~~ /opt/samba/nxa06898/zephyrproject/modules/hal/nxp/mcux/mcux-sdk/devices/MIMXRT798S/drivers/fsl_power.c:387:5: error: 'SCB' undeclared (first use in this function) 387 | SCB->SCR &= ~SCB_SCR_SLEEPDEEP_Msk; | ^~~ /opt/samba/nxa06898/zephyrproject/modules/hal/nxp/mcux/mcux-sdk/devices/MIMXRT798S/drivers/fsl_power.c:387:18: error: 'SCB_SCR_SLEEPDEEP_Msk' undeclared (first use in this function) 387 | SCB->SCR &= ~SCB_SCR_SLEEPDEEP_Msk; | ^~~~~~~~~~~~~~~~~~~~~ /opt/samba/nxa06898/zephyrproject/modules/hal/nxp/mcux/mcux-sdk/devices/MIMXRT798S/drivers/fsl_power.c:388:5: warning: implicit declaration of function '__WFI' [-Wimplicit-function-declaration] 388 | __WFI(); | ^~~~~ /opt/samba/nxa06898/zephyrproject/modules/hal/nxp/mcux/mcux-sdk/devices/MIMXRT798S/drivers/fsl_power.c:389:5: warning: implicit declaration of function '__set_PRIMASK' [-Wimplicit-function-declaration] 389 | __set_PRIMASK(pmsk); | ^~~~~~~~~~~~~ /opt/samba/nxa06898/zephyrproject/modules/hal/nxp/mcux/mcux-sdk/devices/MIMXRT798S/drivers/fsl_power.c: In function 'POWER_EnableAutoWake': /opt/samba/nxa06898/zephyrproject/modules/hal/nxp/mcux/mcux-sdk/devices/MIMXRT798S/drivers/fsl_power.c:396:24: error: 'PMC_IRQn' undeclared (first use in this function); did you mean 'PMC0_IRQn'? 396 | EnableDeepSleepIRQ(PMC_IRQn); | ^~~~~~~~ | PMC0_IRQn /opt/samba/nxa06898/zephyrproject/modules/hal/nxp/mcux/mcux-sdk/devices/MIMXRT798S/drivers/fsl_power.c: In function 'initXSPI': /opt/samba/nxa06898/zephyrproject/modules/hal/nxp/mcux/mcux-sdk/devices/MIMXRT798S/drivers/fsl_power.c:822:5: warning: implicit declaration of function '__DSB' [-Wimplicit-function-declaration] 822 | __DSB(); | ^~~~~ /opt/samba/nxa06898/zephyrproject/modules/hal/nxp/mcux/mcux-sdk/devices/MIMXRT798S/drivers/fsl_power.c:823:5: warning: implicit declaration of function '__ISB' [-Wimplicit-function-declaration] 823 | __ISB(); | ^~~~~ /opt/samba/nxa06898/zephyrproject/modules/hal/nxp/mcux/mcux-sdk/devices/MIMXRT798S/drivers/fsl_power.c: In function 'POWER_EnterLowPower_FullConfig': /opt/samba/nxa06898/zephyrproject/modules/hal/nxp/mcux/mcux-sdk/devices/MIMXRT798S/drivers/fsl_power.c:988:5: error: 'SCB' undeclared (first use in this function) 988 | SCB->SCR |= SCB_SCR_SLEEPDEEP_Msk; | ^~~ /opt/samba/nxa06898/zephyrproject/modules/hal/nxp/mcux/mcux-sdk/devices/MIMXRT798S/drivers/fsl_power.c:988:17: error: 'SCB_SCR_SLEEPDEEP_Msk' undeclared (first use in this function) 988 | SCB->SCR |= SCB_SCR_SLEEPDEEP_Msk; | ^~~~~~~~~~~~~~~~~~~~~ ninja: build stopped: subcommand failed.

If I want to overpass this I need to put a lot of ifdef in the fsl_power.h and fsl_power.c
Can we have a power driver just for DSP?

How do you see these errors fixed?

@lucien-nxp can you please add the following restriction for fsl_power.c?

diff --git a/mcux/CMakeLists.txt b/mcux/CMakeLists.txt index 94de25cb..bf627074 100644 --- a/mcux/CMakeLists.txt +++ b/mcux/CMakeLists.txt @@ -48,7 +48,10 @@ zephyr_compile_definitions(${MCUX_CPU}) # build scripts for every mcux device. zephyr_library_sources(mcux-sdk/devices/${MCUX_DEVICE_PATH}/drivers/fsl_clock.c) if (${MCUX_DEVICE} MATCHES "LPC|MIMXRT6|MIMXRT5|MIMXRT7|RW6|MCXN.4.") - zephyr_library_sources(mcux-sdk/devices/${MCUX_DEVICE_PATH}/drivers/fsl_power.c) + # fsl_power.c contains ARM specific symbols, which shouldn't be included for Xtensa cores + if (NOT ${MCUX_DEVICE} MATCHES "_dsp|_hifi1|_hifi4") + zephyr_library_sources(mcux-sdk/devices/${MCUX_DEVICE_PATH}/drivers/fsl_power.c) + endif() zephyr_library_sources(mcux-sdk/devices/${MCUX_DEVICE_PATH}/drivers/fsl_reset.c) zephyr_library_sources_ifdef(CONFIG_HWINFO_RW61X mcux-sdk/devices/${MCUX_DEVICE}/drivers/fsl_ocotp.c) endif()

This will fix the compilation for HiFi1 and HiFi4 on i.MXRT700.

I want to use this PR in west.yml for nxp_hal, for DSP support - which will be posted on Zephyr repo in the next few days.

Thank you for pointing the solutions. Sorry I ignored HIFI core support before, I have updated the code.

lucien-nxp · 2024-10-20T13:28:50Z

Only rebase to master's newest commit point.

lucien-nxp · 2024-10-22T07:56:15Z

Use device_system_MIMXRT798S_cm33_core0/device_system_MIMXRT798S_cm33_core1 to distinguish two different cm33 cores.
This request is from zephyr side, need to fix in hal_nxp.cmake

iuliana-prodan · 2024-10-23T21:00:33Z

@lucien-nxp can you please rebase this on top of latest nxp_hal, because now on my Zephyr PR a test is falling because in nxp_hal is missing the following commit: 683c007, actually in this PR is missing that commit (becase my PR uses this as hal_nxp version).

In my PR the failing test is: west twister -p s32z2xxdc2@B/s32z270/rtu1 -s tests/drivers/spi/spi_loopback/drivers.spi.s32z_dspi.loopback - see https://github.com/zephyrproject-rtos/zephyr/actions/runs/11480096263/job/31951547309?pr=79954#step:12:483

cc: @dleach02 @Dat-NguyenDuy @mmahadevan108 @manuargue @tunguyen4585

lucien-nxp · 2024-10-24T02:11:46Z

@lucien-nxp can you please rebase this on top of latest nxp_hal, because now on my Zephyr PR a test is falling because in nxp_hal is missing the following commit: 683c007, actually in this PR is missing that commit (becase my PR uses this as hal_nxp version).

In my PR the failing test is: west twister -p s32z2xxdc2@B/s32z270/rtu1 -s tests/drivers/spi/spi_loopback/drivers.spi.s32z_dspi.loopback - see https://github.com/zephyrproject-rtos/zephyr/actions/runs/11480096263/job/31951547309?pr=79954#step:12:483

cc: @dleach02 @Dat-NguyenDuy @mmahadevan108 @manuargue @tunguyen4585

Updated. Please rebase your PR on zephyr side and re-test on CI

add RT700 files from sdk github main branch Signed-off-by: Lucien Zhao <lucien.zhao@nxp.com>

update used data_version from 14 to 16 Signed-off-by: Lucien Zhao <lucien.zhao@nxp.com>

Change RT700 platforms pinctrl model as below: offset(12bits)+index(3bits)+mux(4bits) combined as a uint32_t Add RT700 pin header files using RT700 V16 tool data source Update RT500 pin header files using RT500 V16 tool data source Signed-off-by: Lucien Zhao <lucien.zhao@nxp.com>

lucien-nxp changed the title ~~Rt700 update~~ RT700 update Oct 3, 2024

zephyrbot mentioned this pull request Oct 3, 2024

Add RT700 basic environment support zephyrproject-rtos/zephyr#79376

Open

iuliana-prodan reviewed Oct 14, 2024

View reviewed changes

lucien-nxp force-pushed the rt700_update branch from c9a35ae to 2ba2f19 Compare October 15, 2024 11:15

dleach02 requested a review from iuliana-prodan October 15, 2024 20:25

zephyrbot mentioned this pull request Oct 16, 2024

i.MX RT700 DSP support zephyrproject-rtos/zephyr#79954

Open

lucien-nxp force-pushed the rt700_update branch from 2ba2f19 to e9d5cfe Compare October 20, 2024 13:28

iuliana-prodan approved these changes Oct 21, 2024

View reviewed changes

lucien-nxp force-pushed the rt700_update branch from e9d5cfe to 9e0921b Compare October 22, 2024 07:42

lucien-nxp force-pushed the rt700_update branch from 9e0921b to d6d6aaa Compare October 24, 2024 02:10

lucien-nxp force-pushed the rt700_update branch from d6d6aaa to 8a576e0 Compare November 15, 2024 02:09

lucien-nxp force-pushed the rt700_update branch 2 times, most recently from 429adb2 to d26dc65 Compare December 3, 2024 02:55

lucien-nxp added 3 commits December 12, 2024 16:47

mcux: add RT700 files

c75c786

add RT700 files from sdk github main branch Signed-off-by: Lucien Zhao <lucien.zhao@nxp.com>

mcux: scripts: pinctrl: update used data_version from 14 to 16

eb669aa

update used data_version from 14 to 16 Signed-off-by: Lucien Zhao <lucien.zhao@nxp.com>

lucien-nxp force-pushed the rt700_update branch from d26dc65 to 7a590f3 Compare December 12, 2024 12:10

lucien-nxp changed the title ~~RT700 update~~ add RT700 NPI files firstly Dec 19, 2024

zephyrbot mentioned this pull request Dec 22, 2024

Add rt700 lpadc support zephyrproject-rtos/zephyr#83308

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add RT700 NPI files firstly #444

add RT700 NPI files firstly #444

lucien-nxp commented Oct 3, 2024

iuliana-prodan Oct 14, 2024

iuliana-prodan Oct 15, 2024 •

edited

Loading

lucien-nxp Oct 15, 2024

lucien-nxp commented Oct 20, 2024

lucien-nxp commented Oct 22, 2024

iuliana-prodan commented Oct 23, 2024 •

edited

Loading

lucien-nxp commented Oct 24, 2024 •

edited

Loading

add RT700 NPI files firstly #444

Are you sure you want to change the base?

add RT700 NPI files firstly #444

Conversation

lucien-nxp commented Oct 3, 2024

iuliana-prodan Oct 14, 2024

Choose a reason for hiding this comment

iuliana-prodan Oct 15, 2024 • edited Loading

Choose a reason for hiding this comment

lucien-nxp Oct 15, 2024

Choose a reason for hiding this comment

lucien-nxp commented Oct 20, 2024

lucien-nxp commented Oct 22, 2024

iuliana-prodan commented Oct 23, 2024 • edited Loading

lucien-nxp commented Oct 24, 2024 • edited Loading

iuliana-prodan Oct 15, 2024 •

edited

Loading

iuliana-prodan commented Oct 23, 2024 •

edited

Loading

lucien-nxp commented Oct 24, 2024 •

edited

Loading