Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcux: MIMXRT1189 select correct mu1 driver for RT1180 devices #478

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TomasGalbickaNXP
Copy link
Contributor

No description provided.

Signed-off-by: Tomas Galbicka <tomas.galbicka@nxp.com>
Copy link
Contributor

@DerekSnell DerekSnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the hal_nxp.cmake file already limits to the derivative RT1189. But these inclusions should be more general to include more derivatives in the RT1180 family.

@@ -284,7 +284,7 @@ elseif(CONFIG_SOC_MIMXRT1189_CM33)
include_driver_ifdef(CONFIG_HAS_MCUX_CACHE cache/xcache driver_cache_xcache)
endif()

if (${MCUX_DEVICE} MATCHES "MIMX9596")
if (${MCUX_DEVICE} MATCHES "MIMX9596" OR ${MCUX_DEVICE} MATCHES "MIMXRT1189")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (${MCUX_DEVICE} MATCHES "MIMX9596" OR ${MCUX_DEVICE} MATCHES "MIMXRT1189")
if (${MCUX_DEVICE} MATCHES "MIMX9596" OR ${MCUX_DEVICE} MATCHES "MIMXRT118")

There are other derivatives in the RT1180 family, which all include the M7 core and MU.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants