Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zephyr integration: Use K_HEAP_MEM_POOL_SIZE #23

Closed
wants to merge 1 commit into from

Conversation

jhedberg
Copy link
Member

@jhedberg jhedberg commented Dec 8, 2023

This define should be used instead of the Kconfig option to determine if the k_malloc family of functions are available.

@jhedberg
Copy link
Member Author

jhedberg commented Dec 8, 2023

@arnopo
Copy link
Collaborator

arnopo commented Dec 11, 2023

Could you confirm if it is compatible with legacy versions of Zephyr?

@jhedberg
Copy link
Member Author

Could you confirm if it is compatible with legacy versions of Zephyr?

@arnopo no, older Zephyr versions don't have a K_HEAP_MEM_POOL_SIZE define. However, older versions of Zephyr also wouldn't reference a newer version of the libmetal tree through west.yml, so I don't think there should be any issue with that.

Btw, note that the discussion in zephyrproject-rtos/zephyr#65908 is still ongoing, so I would suggest to wait for a consensus to be reached there before merging this PR.

@jhedberg
Copy link
Member Author

There was sufficient consensus in today's Arch WG meeting on how to proceed, that I think this can be merged now. After that I'll update the main tree PR west.yml to reference the right commit.

@arnopo
Copy link
Collaborator

arnopo commented Dec 13, 2023

There was sufficient consensus in today's Arch WG meeting on how to proceed, that I think this can be merged now. After that I'll update the main tree PR west.yml to reference the right commit.

The zephyrproject-rtos/zephyr#65523 PR would need to be addressed first. the rebase on the v2023.10 released is blocked due to a test that fails

@arnopo
Copy link
Collaborator

arnopo commented Dec 14, 2023

@jhedberg :
Please Could you send a PR to libmetal github?
The normal process is to integrate it in lib metal and then rebase this repo.
if something takes to much time in the libmetal review process we will merge this one to unblock #65908

@jhedberg
Copy link
Member Author

@jhedberg : Please Could you send a PR to libmetal github? The normal process is to integrate it in lib metal and then rebase this repo. if something takes to much time in the libmetal review process we will merge this one to unblock #65908

Done: OpenAMP/libmetal#280

This define should be used instead of the Kconfig option to determine if
the k_malloc family of functions are available.

Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
@arnopo
Copy link
Collaborator

arnopo commented Dec 15, 2023

@carlocaione : Please could you review OpenAMP/libmetal#280. Then I will merge it and create a PR to rebase the Zephyr libmetal module on top of.

@jhedberg : I assume that you will update the west.yml in zephyrproject-rtos/zephyr#65908 then to integrate it, right?

@jhedberg
Copy link
Member Author

@jhedberg : I assume that you will update the west.yml in zephyrproject-rtos/zephyr#65908 then to integrate it, right?

Correct.

@arnopo
Copy link
Collaborator

arnopo commented Dec 15, 2023

@jhedberg : I created #25

@jhedberg
Copy link
Member Author

jhedberg commented Dec 18, 2023

Closing, now that this has been superseded by #25

@jhedberg jhedberg closed this Dec 18, 2023
@jhedberg jhedberg deleted the heap_mem_pool branch December 18, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants