Skip to content

Conversation

bdmendes
Copy link

@bdmendes bdmendes commented Aug 7, 2023

Since zephyrproject-rtos/zephyr@c3eeae8, Zephyr OS exposes offset of mode_exc_return in the arch struct for ARM.

Accounting for this allows for consistency and enables logic with further offsets that may be added after this.

Since zephyrproject-rtos/zephyr@c3eeae8,
Zephyr OS exposes offset of mode_exc_return in the arch struct for ARM.

Accounting for this allows for consistency and enables
logic with further offsets that may be added after this.

Signed-off-by: Bruno Mendes <bd_mendes@outlook.com>
Copy link
Contributor

@abrodkin abrodkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me but would be good to submit it upstream as well for consistency.

Copy link
Contributor

@EvgeniiDidin EvgeniiDidin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bdmendes
Copy link
Author

bdmendes commented Aug 8, 2023

This is now under review in upstream: https://review.openocd.org/c/openocd/+/7851

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants