Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USB MSC fails USB3CV tests #14302

Closed
5 tasks done
masz-nordic opened this issue Mar 12, 2019 · 5 comments · Fixed by #23307
Closed
5 tasks done

USB MSC fails USB3CV tests #14302

masz-nordic opened this issue Mar 12, 2019 · 5 comments · Fixed by #23307
Assignees
@jfischer-no @carlescufi @eobalski
Labels
area: USB Universal Serial Bus bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@masz-nordic
Copy link
Collaborator

masz-nordic commented Mar 12, 2019 •
edited by eobalski
Loading

Describe the bug
USB mass storage sample with RAM disk fails USB3CV (#11803) MSC specific tests:

  • Error Recovery
  • Case 3
  • Case 12
  • CB Length
  • Command Set

To Reproduce
Flash mass sample with RAM overlay to nrf52840_pca10056.

Expected behavior
USB3CV MSC tests pass.

Impact
No immediate impact, but this has to be solved before MSC class is considered ready.

Screenshots or console output
Three unique errors are thrown in tests:

  1. Error Recovery
Issuing required command (Test Unit Ready) to verify device has recovered
Issuing CBW (attempt #1):
|----- CBW LUN                  = 0x0
|----- CBW Flags                = 0x0
|----- CBW Data Transfer Length = 0x0
|----- CBW CDB Length           = 0x6
|----- CBW CDB-00 = 0x0
|----- CBW CDB-01 = 0x0
|----- CBW CDB-02 = 0x0
|----- CBW CDB-03 = 0x0
|----- CBW CDB-04 = 0x0
|----- CBW CDB-05 = 0x0
Issuing CSW : try 1
CSW Bulk Request timed out!

ERROR
Failed CSW phase : should have been success or stall
FAIL
(5.3.4) The CSW status value must be 0x00, 0x01, or 0x02.

Re-enumerating device
Detected hard error, issuing BOT MSC Reset

ERROR
Failed to execute required command (Test Unit Ready) after BOT MSC Reset
FAIL
(5.7.2) All devices must either support or properly fail the commands marked 
 as optional in 4.2 based on PDT. Devices that support or properly fail all the commands 
 marked as optional for Bootable devices will be reported as Bootable.
  1. Case 3, Case 12, CB Length, Command Set:
Issuing INQUIRY
Issuing CBW (attempt #1):
|----- CBW LUN                  = 0x0
|----- CBW Flags                = 0x80
|----- CBW Data Transfer Length = 0x24
|----- CBW CDB Length           = 0x6
|----- CBW CDB-00 = 0x12
|----- CBW CDB-01 = 0x0
|----- CBW CDB-02 = 0x0
|----- CBW CDB-03 = 0x0
|----- CBW CDB-04 = 0x24
|----- CBW CDB-05 = 0x0
Issuing DATA IN
DATA Bulk Request timed out!

ERROR
Failed DATA phase : should have been success or stall!
FAIL
(5.2.3) Devices must consider the CBW meaningful if no reserved bits 
 are set, the LUN number indicates a LUN supported by the device, 
 bCBWCBLength is in the range of 1 through 16, and the length and 
 content of the CBWCB field are appropriate to the SubClass.

Re-enumerating device
Detected hard error, issuing BOT MSC Reset

ERROR
Failed INQUIRY request
FAIL
(5.7.1) All devices must support the commands marked as required in 4.2 based 
 on PDT. Devices that support all the commands marked as required for Bootable devices will 
 be reported as Bootable.
  1. Command Set:
Issuing Command Set Test for Op Code 0x12, Test Variation #3
Issuing CBW (attempt #1):
|----- CBW LUN                  = 0x0
|----- CBW Flags                = 0x80
|----- CBW Data Transfer Length = 0x2
|----- CBW CDB Length           = 0x6
|----- CBW CDB-00 = 0x12
|----- CBW CDB-01 = 0x0
|----- CBW CDB-02 = 0x0
|----- CBW CDB-03 = 0x0
|----- CBW CDB-04 = 0x2
|----- CBW CDB-05 = 0x0
Issuing DATA IN
DATA Bulk Request timed out!

ERROR
Failed DATA phase : should have been success or stall!

FAIL
(5.2.3) Devices must consider the CBW meaningful if no reserved bits 
 are set, the LUN number indicates a LUN supported by the device, 
 bCBWCBLength is in the range of 1 through 16, and the length and 
 content of the CBWCB field are appropriate to the SubClass.

ERROR
READ CAPACITY(10) not supported.

Environment (please complete the following information):

  • OS: Windows x64 7 Professional SP1
  • PC: Dell Optiplex 9020
  • DK: nrf52840_pca10056
  • Toolchain: Zephyr SDK 0.9.5
  • Zephyr b87920b
@masz-nordic masz-nordic added bug The issue is a bug, or the PR is fixing a bug area: USB Universal Serial Bus labels Mar 12, 2019
@carlescufi carlescufi added the priority: low Low impact/importance bug label Mar 12, 2019
@nashif nashif modified the milestones: v1.14.0, future Apr 2, 2019
@nashif nashif removed this from the future milestone May 21, 2019
@carlescufi carlescufi added the platform: nRF Nordic nRFx label Jun 3, 2019
@jfischer-no
Copy link
Collaborator

@emob-nordic Can you rerun USB3CV MSC specific test, please?

@eobalski
Copy link
Collaborator

@jfischer-phytec-iot Same test have failed:

  • Error Recovery
  • Case 3
  • Case 12
  • CB Length
  • Command Set

@jfischer-no jfischer-no added this to the v2.2.0 milestone Feb 5, 2020
@jfischer-no jfischer-no self-assigned this Feb 5, 2020
@jfischer-no jfischer-no removed the platform: nRF Nordic nRFx label Feb 5, 2020
@jfischer-no jfischer-no modified the milestones: v2.2.0, v2.3.0 Feb 28, 2020
This was referenced Feb 28, 2020
Closed
Merged
@eobalski eobalski added the has-pr label Mar 6, 2020
@eobalski eobalski reopened this Jun 18, 2020
@eobalski eobalski removed the has-pr label Jun 18, 2020
@eobalski eobalski removed this from the v2.3.0 milestone Jun 18, 2020
@eobalski
Copy link
Collaborator

eobalski commented Jun 18, 2020 •
edited
Loading

USB MSC fails 'Command Set Test' from USB3CV.
Platform: nRF52840dk (nRF52840dk_nrf52840).

Issuing DATA OUT
Issuing CSW : try 1
CSW residue returned = 0x0
CSW status returned = 0x0
Issuing Command Set Test for Op Code 0xaa, Test Variation #5
Issuing CBW (attempt #1):
|----- CBW LUN                  = 0x0
|----- CBW Flags                = 0x0
|----- CBW Data Transfer Length = 0x10000
|----- CBW CDB Length           = 0xc
|----- CBW CDB-00 = 0xaa
|----- CBW CDB-01 = 0x0
|----- CBW CDB-02 = 0x0
|----- CBW CDB-03 = 0x0
|----- CBW CDB-04 = 0x0
|----- CBW CDB-05 = 0x0
|----- CBW CDB-06 = 0x0
|----- CBW CDB-07 = 0x0
|----- CBW CDB-08 = 0x0
|----- CBW CDB-09 = 0x80
|----- CBW CDB-10 = 0x0
|----- CBW CDB-11 = 0x0
Issuing DATA OUT
DATA Bulk Request timed out!
Failed DATA phase : should have been success or stall!
(MSC: 5.2.3) Devices must consider the CBW meaningful if no reserved bits are set, the LUN number indicates a LUN supported by the device, bCBWCBLength is in the range of 1 through 16, and the length and content of the CBWCB field are appropriate to the SubClass.
Re-enumerating device
Detected hard error, issuing BOT MSC Reset


+ + + + + 

Getting Device Type
Issuing INQUIRY
Issuing CBW (attempt #1):
|----- CBW LUN                  = 0x0
|----- CBW Flags                = 0x80
|----- CBW Data Transfer Length = 0x24
|----- CBW CDB Length           = 0x6
|----- CBW CDB-00 = 0x12
|----- CBW CDB-01 = 0x0
|----- CBW CDB-02 = 0x0
|----- CBW CDB-03 = 0x0
|----- CBW CDB-04 = 0x24
|----- CBW CDB-05 = 0x0
CBW Bulk Request timed out!
Failed CBW phase, should have been successful!
(MSC: 5.2.3) Devices must consider the CBW meaningful if no reserved bits are set, the LUN number indicates a LUN supported by the device, bCBWCBLength is in the range of 1 through 16, and the length and content of the CBWCB field are appropriate to the SubClass.
Re-enumerating device
Detected hard error, issuing BOT MSC Reset
Failed INQUIRY request
(MSC: 5.7.1) All devices must support the commands marked as required in 4.2 based on PDT.  Devices that support all the commands marked as required for Bootable devices will be reported as Bootable.



READ CAPACITY(16) not supported.

The issue was introduced by #24696. cc @pabigot.

@pabigot
Copy link
Collaborator

pabigot commented Jun 18, 2020

@emob-nordic Please open a new issue for this as the original issue was fixed. I'll take a look to see what might have caused the problem.

@pabigot pabigot closed this as completed Jun 18, 2020
@pabigot pabigot mentioned this issue Jun 18, 2020
Closed
@pabigot
Copy link
Collaborator

pabigot commented Jun 18, 2020

@emob-nordic never mind, I've done it: #26275

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jfischer-no jfischer-no

@carlescufi carlescufi

@eobalski eobalski

Labels
area: USB Universal Serial Bus bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

usb: mass_storage: cleanup, fixes to pass USBCV MSC Test jfischer-no/zephyr
6 participants
@nashif @pabigot @jfischer-no @carlescufi @masz-nordic @eobalski