samples: usb: mass: demonstrate mounting littlefs file systems on Linux/FreeBSD hosts #24696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flash drivers may impose alignment requirements on the destination buffers due to use of DMA transfers. In particular Nordic QSPI flash API requires that addresses, sizes, and buffers all by 4-byte aligned. Align the page buffer to satisfy this requirement. Signed-off-by: Peter A. Bigot <pab@pabigot.com>
Flash drivers may impose alignment requirements on the destination buffers due to use of DMA transfers. In particular Nordic QSPI flash API requires that addresses, sizes, and buffers all be 4-byte aligned. Align the ready/copy buffer to satisfy this requirement. Signed-off-by: Peter A. Bigot <pab@pabigot.com>
The API call to close the flash area was only invoked when the flash area was erased. It should be closed in all paths. Signed-off-by: Peter A. Bigot <pab@pabigot.com>
Drop the old redefine-everything-in-a-special-conf approach and put the customization appropriate for this board into the board directory where it's handled automatically. Signed-off-by: Peter A. Bigot <pab@pabigot.com>
pabigot
added
area: File System
area: USB
|
All checks are passing now. Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages. |
This allows mass storage exposure of a littlefs file system, specifically one on the SPI NOR flash of the nrf52840dk_nrf52840. In combination with littlefs-fuse this allows a host system to examine and change the local storage of a Zephyr application. Note that it is critical that all parameters of the file system match between what Zephyr is using and what littlefs-fuse is using. Inconsistencies can produce confusing results where each system sees different content. The README has been updated with a detailed example. Signed-off-by: Peter A. Bigot <pab@pabigot.com>
pabigot
force-pushed
the
pabigot/20200425a
branch
from
96cba5b to
e5e34d8
Compare
jfischer-no
approved these changes
May 5, 2020
| */ | ||
| static u8_t page[BLOCK_SIZE + CONFIG_MASS_STORAGE_BULK_EP_MPS]; | ||
| static u8_t __aligned(4) page[BLOCK_SIZE + CONFIG_MASS_STORAGE_BULK_EP_MPS]; |
There was a problem hiding this comment.
__aligned(sizeof(u32_t)) ?
There was a problem hiding this comment.
Most existing _aligned attributes in Zephyr use integer values directly rather than deriving them from sizeof(type).
| @@ -19,7 +19,7 @@ | |||
| static struct device *flash_dev; | |||
|
|
|||
| /* flash read-copy-erase-write operation */ | |||
| static u8_t read_copy_buf[CONFIG_DISK_ERASE_BLOCK_SIZE]; | |||
| static u8_t __aligned(4) read_copy_buf[CONFIG_DISK_ERASE_BLOCK_SIZE]; | |||
There was a problem hiding this comment.
__aligned(sizeof(u32_t)) ?
carlescufi
approved these changes
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The https://github.com/ARMmbed/littlefs-fuse project in combination with Zephyr's USB Mass Storage support allows mounting embedded file systems directly onto Linux and FreeBSD hosts for inspection and modification.