add alignment to high-level flash clients #24489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabigot
added
area: USB
Flash drivers may impose alignment requirements on the destination buffers due to use of DMA transfers. In particular Nordic QSPI flash API requires that addresses, sizes, and buffers all by 4-byte aligned. Align the page buffer to satisfy this requirement. Signed-off-by: Peter A. Bigot <pab@pabigot.com>
Flash drivers may impose alignment requirements on the destination buffers due to use of DMA transfers. In particular Nordic QSPI flash API requires that addresses, sizes, and buffers all be 4-byte aligned. Align the ready/copy buffer to satisfy this requirement. Signed-off-by: Peter A. Bigot <pab@pabigot.com>
pabigot
force-pushed
the
pabigot/20200418b
branch
from
e502a27 to
3626fd2
Compare
|
This isn't getting attention, so close the separate PR and have it reviewed in the context of #24696 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The USB mass storage infrastructure uses the disk-access API with alternative underlying drivers, one of which can be flash, which can be instantiated as Nordic QSPI, which requires that data buffers be 4-byte aligned. Add the buffer alignments necessary to allow export of QSPI-based flash file systems through the USB mass storage class.