Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing system calls in Counter driver APIs #14650

Closed
andrewboie opened this issue Mar 18, 2019 · 1 comment · Fixed by #22030
Closed

missing system calls in Counter driver APIs #14650

andrewboie opened this issue Mar 18, 2019 · 1 comment · Fixed by #22030
Assignees
@andrewboie
Labels
area: Counter area: Memory Protection Enhancement Changes/Updates/Additions to existing features priority: medium Medium impact/importance bug

Comments

@andrewboie
Copy link
Contributor

We do not have system calls implemented for some of the counter APIs, preventing access from user mode.

counter_is_counting_up()
counter_get_num_of_channels()
counter_get_frequency()
counter_us_to_ticks()
counter_ticks_to_us()
counter_get_max_top_value()
counter_cancel_channel_alarm()
@andrewboie andrewboie added Enhancement Changes/Updates/Additions to existing features area: Counter area: Memory Protection labels Mar 18, 2019
@andrewboie
Copy link
Contributor Author

Most of these pull values out of dev->config->config_info

config_info is a struct in ROM and should be directly readable by user mode.
We might be able to implement a generic k_driver_config_get() system call which returns a pointer to the config struct, and these APIs could be done in terms of that, rather than a syscall for each one.

@andrewboie andrewboie self-assigned this Mar 18, 2019
@andrewboie andrewboie added this to the v1.15.0 milestone Mar 18, 2019
@andrewboie andrewboie added the priority: medium Medium impact/importance bug label Mar 18, 2019
@andrewboie andrewboie removed this from the v1.15.0 milestone Mar 19, 2019
@henrikbrixandersen henrikbrixandersen mentioned this issue Jan 20, 2020
Merged
henrikbrixandersen added a commit to henrikbrixandersen/zephyr that referenced this issue Jan 21, 2020
@henrikbrixandersen
drivers: counter: add missing syscalls
94247b4 
Add missing syscalls and fix already present syscalls for the counter
API.

Fixes zephyrproject-rtos#14650.

Signed-off-by: Henrik Brix Andersen <henrik@brixandersen.dk>
nashif pushed a commit that referenced this issue Jan 21, 2020
@henrikbrixandersen @nashif
drivers: counter: add missing syscalls
0f60477 
Add missing syscalls and fix already present syscalls for the counter
API.

Fixes #14650.

Signed-off-by: Henrik Brix Andersen <henrik@brixandersen.dk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewboie andrewboie

Labels
area: Counter area: Memory Protection Enhancement Changes/Updates/Additions to existing features priority: medium Medium impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing counter API syscalls henrikbrixandersen/zephyr
1 participant
@andrewboie