Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soc/x86/apollo_lake/soc_gpio.h: leading zeros on decimal constants #15463

Closed
ghost opened this issue Apr 15, 2019 · 0 comments · Fixed by #15464
Closed

soc/x86/apollo_lake/soc_gpio.h: leading zeros on decimal constants #15463

ghost opened this issue Apr 15, 2019 · 0 comments · Fixed by #15464
Labels
bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@ghost
Copy link

ghost commented Apr 15, 2019

Describe the bug

Some constants intended to be in base 10 are unintentionally in base 8, and are therefore malformed, e.g.,:

#define APL_GPIO_8 08

The leading zeroes should be stripped. The compiler will choke on these if they're used.
@ghost ghost added bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug labels Apr 15, 2019
@ghost ghost self-assigned this Apr 15, 2019
@ghost ghost mentioned this issue Apr 15, 2019
Merged
nashif pushed a commit that referenced this issue Apr 16, 2019
@nashif
soc/x86/apollo_lake: strip leading zeros from decimal constants
468df53 
Remove leading zeros from decimal constants, because long live octal.

Fixes: #15463

Signed-off-by: Charles E. Youse <charles.youse@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

soc/x86/apollo_lake: strip leading zeros from decimal constants
0 participants