[Coverity CID :205823] Null pointer dereferences in tests/kernel/fifo/fifo_timeout/src/main.c

[zephyrbot]

Static code scan issues found in file:

https://github.com/zephyrproject-rtos/zephyr/tree/master/tests/kernel/fifo/fifo_timeout/src/main.c

Category: Null pointer dereferences
Function: test_multiple_threads_pending
Component: Tests
CID: 205823

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v32951/p12996.

[andyross]

Triage for whoever's benefit: this one is real enough.

test_multiple_threads_pending() does a k_fifo_get() to retrieve a data pointer and then dereferences it to log its fields in a TC_PRINT() at line 162. The test is making assumptions about the data environment to assume that the get never returns a NULL, but it technically can and coverity wants that case checked.

It's probably enough to put a z_assert_true(data != NULL, ""); ahead of the use, though it might be safer to wrap the dereferences in an if() instead.