[Coverity CID :206393] Unintentional integer overflow in drivers/sensor/ms5607/ms5607.c

[zephyrbot]

Static code scan issues found in file:

https://github.com/zephyrproject-rtos/zephyr/tree/53392ad403db3a3c63e5802e620ead569306b978/drivers/sensor/ms5607/ms5607.c#L46

Category: Integer handling issues
Function: ms5607_compensate
Component: Drivers
CID: 206393

Details:

40    
41         /* Second order compensation as per datasheet
42          * (https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0TEF4VnH9i4TTIUca3VjgWqR5l81E0p6T-2FViHGDkSsAj65ka8TVMpufDw-2BTcrguPPA-3D-3D_qb0Uj4AheYo18oR3ufs7U2EqDpE-2BCuzW5lXxy9dw9-2BA3R8-2ByM7YmWdwvIDfPUpFgx2wpkGg-2FxlOjavYrZghXJf6PWXyrC70buJ8HmWAgQWXAurgcxgm8aCWoixXlxrnC1YUHdMLIIwn7xm-2BS2i5zfvhCtszeMz-2FaE23P6qqCPyAnhlI7AxQa3sJCrVaOXd4xVaOq3gKrfE-2BYPjcw0C4cm1QHMgEKQ13L0nDixFikyTrfV5Z7KMUj1JClPTICyCrM section
43          * SECOND ORDER TEMPERATURE COMPENSATION
44          */
45    
>>>     CID 206393:  Integer handling issues  (OVERFLOW_BEFORE_WIDEN)
>>>     Potentially overflowing expression "(data->temperature - 2000) * (data->temperature - 2000)" with type "int" (32 bits, signed) is evaluated using 32-bit arithmetic, and then used in a context that expects an expression of type "s64_t" (64 bits, signed).
46         temp_sq = (data->temperature - 2000) * (data->temperature - 2000);
47         if (data->temperature < 2000) {
48             Ti = (dT * dT) / (1ll << 31);
49             OFFi = (61ll * temp_sq) / (1ll << 4);
50             SENSi = 2ll * temp_sq;
51             if (data->temperature < -1500) {

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v32951/p12996.

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.