Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bluetooth - peripheral_dis - settings_runtime_set not working #22478

Closed
novalisek opened this issue Feb 4, 2020 · 3 comments · Fixed by #22500
Closed

Bluetooth - peripheral_dis - settings_runtime_set not working #22478

novalisek opened this issue Feb 4, 2020 · 3 comments · Fixed by #22500
Assignees
@joerchan
Labels
area: Bluetooth bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@novalisek
Copy link

Describe the bug
Hi, I would like to change DIS model name, manufacturer etc from code, I tried to change them in peripheral_dis main.c but there is no change when scanned.

To Reproduce
keep
CONFIG_BT_GATT_DIS_MODEL="Zephyr Model"
in prj.conf
change "Zephyr model" to "Zephyr model mod" in main.c on lines 52+53.
build and flash

Expected behavior
when you read DIS model characteristic, it still contains "Zephyr model", not "Zephyr model mod"

Impact
For me, if example is not working as expected, I don't know where to look for problem in my own code

Environment (please complete the following information):

  • board: nrf52840_pca10040
  • OS: W7
  • Toolchain: GNU ARM Embedded 9-2019-q4
  • Commit SHA or Version used: f21aaef
@novalisek novalisek added the bug The issue is a bug, or the PR is fixing a bug label Feb 4, 2020
@aescolar
Copy link
Member

aescolar commented Feb 5, 2020

CC @jhedberg

@jhedberg
Copy link
Member

jhedberg commented Feb 5, 2020

Are you sure you have settings enabled? I don't see CONFIG_BT_SETTINGS=y in the peripheral_dis prj.conf.

joerchan added a commit to joerchan/zephyr that referenced this issue Feb 5, 2020
@joerchan
Bluetooth: samples: peripheral_dis: Sample requires BT_SETTINGS
277c3d4 
The DIS service requires BT_SETTINGS otherwise it will not have a
settings handler. Instead DIS will only use Kconfig to set it's
values.

Fixes: zephyrproject-rtos#22478

Signed-off-by: Joakim Andersson <joakim.andersson@nordicsemi.no>
@joerchan joerchan added the priority: low Low impact/importance bug label Feb 5, 2020
@joerchan joerchan mentioned this issue Feb 5, 2020
Merged
@novalisek
Copy link
Author

Thanks,
adding CONFIG_BT_SETTINGS=y and using settings_load() helped

jhedberg pushed a commit that referenced this issue Feb 5, 2020
@joerchan @jhedberg
Bluetooth: samples: peripheral_dis: Sample requires BT_SETTINGS
1e80efa 
The DIS service requires BT_SETTINGS otherwise it will not have a
settings handler. Instead DIS will only use Kconfig to set it's
values.

Fixes: #22478

Signed-off-by: Joakim Andersson <joakim.andersson@nordicsemi.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joerchan joerchan

Labels
area: Bluetooth bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bluetooth: samples: peripheral_dis: Sample requires BT_SETTINGS joerchan/zephyr
4 participants
@jhedberg @joerchan @novalisek @aescolar