Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coverity CID :208203] Missing break in switch in drivers/interrupt_controller/intc_exti_stm32.c #22646

Closed
zephyrbot opened this issue Feb 9, 2020 · 0 comments · Fixed by #22752
Assignees
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix platform: STM32 ST Micro STM32 priority: low Low impact/importance bug

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https://github.com/zephyrproject-rtos/zephyr/tree/e089906b339aad4cd1b6589a3b6ce94782d93f54/drivers/interrupt_controller/intc_exti_stm32.c#L181

Category: Control flow issues
Function: stm32_exti_trigger
Component: Drivers
CID: 208203

Details:

175             LL_EXTI_DisableFallingTrig_0_31(1 << line);
176             break;
177         case STM32_EXTI_TRIG_FALLING:
178             LL_EXTI_EnableFallingTrig_0_31(1 << line);
179             LL_EXTI_DisableRisingTrig_0_31(1 << line);
180             break;
>>>     CID 208203:  Control flow issues  (MISSING_BREAK)
>>>     The case for value "STM32_EXTI_TRIG_BOTH" is not terminated by a 'break' statement.
181         case STM32_EXTI_TRIG_BOTH:
182             LL_EXTI_EnableRisingTrig_0_31(1 << line);
183             LL_EXTI_EnableFallingTrig_0_31(1 << line);
184         default:
185             __ASSERT_NO_MSG(trigger);
186         }

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v32951/p12996.

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.

@zephyrbot zephyrbot added bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug labels Feb 9, 2020
@erwango erwango assigned erwango and unassigned andrewboie Feb 10, 2020
@erwango erwango added the platform: STM32 ST Micro STM32 label Feb 10, 2020
erwango added a commit to erwango/zephyr that referenced this issue Feb 12, 2020
Fix missing break statement is missing in switch/case.

Fixes zephyrproject-rtos#22646

Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>
@erwango erwango added the has-pr label Feb 12, 2020
galak pushed a commit that referenced this issue Feb 12, 2020
Fix missing break statement is missing in switch/case.

Fixes #22646

Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix platform: STM32 ST Micro STM32 priority: low Low impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants