Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards: adafruit_feather_m0: don't throw compiler warnings on using custom sercom config #23133

Closed
KubaFYI opened this issue Feb 27, 2020 · 2 comments · Fixed by #23252
Closed
Labels
RFC Request For Comments: want input from the community

Comments

@KubaFYI
Copy link
Contributor

KubaFYI commented Feb 27, 2020

In order to use it's serial peripheral SERCOMs SAD1 requires their pins to be configured with pinmux. Currently that's enabled only for the board default serial interfaces: the USART TX/RX on sercom0, an SPI interface on sercom4, and the USB port. The pinmux code currently is written to throw a compiler error if a user app tries to use any sercom in a way it wasn't pre-defined to be used. The error claims the pin mapping have not been configured but at the same time it doesn't give a chance for this configuration to take place in app code.

I propose that those errors are changed to warnings which would allow users to proceed with compilation and configure the pin mappings themselves should they wish to use sercom1-sercom3.

The relevant file is pinmux.c

@KubaFYI KubaFYI added the RFC Request For Comments: want input from the community label Feb 27, 2020
@KubaFYI KubaFYI changed the title boards: adafruit_feather_m0: don't throw compiler warnings on using of sercom1-3 boards: adafruit_feather_m0: don't throw compiler warnings on using custom sercom config Feb 27, 2020
@KubaFYI
Copy link
Contributor Author

KubaFYI commented Feb 27, 2020

What do you think @henrikbrixandersen ?

@henrikbrixandersen
Copy link
Member

Sounds like an okay solution to me.

KubaFYI added a commit to KubaFYI/zephyr that referenced this issue Mar 5, 2020
In order to use its serial peripheral SERCOMs SAMD socs require their
pins to be configured with pinmux. Currently pins are muxed only for the
boards' default serial interfaces. The pinmux code is written to throw
a compiler error if a user tries to use any sercom in a way it wasn't
pre-defined to be used.

This commit changes compiler errors to warnings so that user can provide
custom pinmuxing code in their app.

Fixes zephyrproject-rtos#23133

Signed-off-by: Kuba Sanak <contact@kuba.fyi>
galak pushed a commit that referenced this issue Apr 17, 2020
In order to use its serial peripheral SERCOMs SAMD socs require their
pins to be configured with pinmux. Currently pins are muxed only for the
boards' default serial interfaces. The pinmux code is written to throw
a compiler error if a user tries to use any sercom in a way it wasn't
pre-defined to be used.

This commit changes compiler errors to warnings so that user can provide
custom pinmuxing code in their app.

Fixes #23133

Signed-off-by: Kuba Sanak <contact@kuba.fyi>
hakehuang pushed a commit to hakehuang/zephyr that referenced this issue Jun 20, 2020
In order to use its serial peripheral SERCOMs SAMD socs require their
pins to be configured with pinmux. Currently pins are muxed only for the
boards' default serial interfaces. The pinmux code is written to throw
a compiler error if a user tries to use any sercom in a way it wasn't
pre-defined to be used.

This commit changes compiler errors to warnings so that user can provide
custom pinmuxing code in their app.

Fixes zephyrproject-rtos#23133

Signed-off-by: Kuba Sanak <contact@kuba.fyi>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFC Request For Comments: want input from the community
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants