Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32 SDMMC disk access driver (based on stm32 cube HAL) #23555

Closed
anthonybrandon opened this issue Mar 18, 2020 · 6 comments
Closed

STM32 SDMMC disk access driver (based on stm32 cube HAL) #23555

anthonybrandon opened this issue Mar 18, 2020 · 6 comments
Labels
platform: STM32 ST Micro STM32

Comments

@anthonybrandon
Copy link
Contributor

I've written a disk access driver for the stm32 sdmmc component based around the stm32 cube HAL, and I am wondering if there is any interest in merging something like that.
The only related PR I could fine was #13214, but it seems to be abandoned.
If there is interest I will make a PR with my changes.

@anthonybrandon anthonybrandon added the Feature Request A request for a new feature label Mar 18, 2020
@erwango
Copy link
Member

erwango commented Mar 18, 2020

Hi @anthonybrandon,

There is definitely an interest. Don't hesitate to base your work on #13214 which was of a good quality and had well split commits.

@anthonybrandon
Copy link
Contributor Author

@erwango #13214 introduces an API for the low level sdmmc driver (for which I am using stm32 cube). I can upload my change and maybe we can discuss how it should be changed.
If you prefer I push #13214 forward, that is also an option I guess.

@anthonybrandon
Copy link
Contributor Author

My PR: #23561

@erwango
Copy link
Member

erwango commented Mar 18, 2020

Thanks. Let's discuss it there.

@carlescufi carlescufi added Hardware Support and removed Feature Request A request for a new feature labels Apr 14, 2020
@anthonybrandon
Copy link
Contributor Author

@erwango Since my PR is merged I am interested in adding support for interrupts to the driver. Is it okay to discuss here? Or on a slack channel? My main question is if I should just replace the current polling implementation with an interrupt based one, or if it should be some Kconfig option. I'm not sure there is any reason to ever not use the interrupt based implementation if it was available.

@erwango erwango added the platform: STM32 ST Micro STM32 label May 28, 2020
@erwango
Copy link
Member

erwango commented May 28, 2020

@anthonybrandon Let's discuss on Slack or you can also open a new ticket.
At first, I won't see any reason to keep the polling if interrupt is supported, but you can open a RFC and see if there are people concerned by this option.
This being said, this is a new driver so I don't think there will be much more users to complain.

I'm closing this issue as the work is now done.

@erwango erwango closed this as completed May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: STM32 ST Micro STM32
Projects
None yet
Development

No branches or pull requests

3 participants