Initial release of SD/MMC interface driver #13214

pic16f887 · 2019-02-09T18:58:48Z

Pull request contains generic API interface for SD/MMC device and device specific driver for STM32F7 MCU family.

zephyrbot · 2019-02-09T19:04:22Z

All checks are passing now.

Review history of this comment for details about previous failed status.
Note that some checks might have not completed yet.

codecov-io · 2019-02-09T19:43:26Z

Codecov Report

Merging #13214 into master will decrease coverage by 3.37%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #13214      +/-   ##
==========================================
- Coverage   52.12%   48.75%   -3.38%     
==========================================
  Files         316      319       +3     
  Lines       46819    46871      +52     
  Branches    10851    10835      -16     
==========================================
- Hits        24404    22850    -1554     
- Misses      17479    19394    +1915     
+ Partials     4936     4627     -309

Impacted Files	Coverage Δ
lib/libc/minimal/include/stdlib.h	`0% <0%> (-100%)`	⬇️
...ys/bluetooth/controller/ll_sw/nordic/lll/lll_adv.h	`0% <0%> (-88%)`	⬇️
subsys/bluetooth/controller/ll_sw/ull_slave.c	`0% <0%> (-81.77%)`	⬇️
...oth/controller/ll_sw/nordic/lll/lll_adv_internal.h	`0% <0%> (-76.48%)`	⬇️
.../bluetooth/controller/ll_sw/nordic/lll/lll_slave.c	`0% <0%> (-65.52%)`	⬇️
...ys/bluetooth/controller/ll_sw/nordic/lll/lll_adv.c	`2.16% <0%> (-55.85%)`	⬇️
subsys/bluetooth/controller/ll_sw/ull_adv.c	`5.45% <0%> (-43.18%)`	⬇️
subsys/net/ip/dhcpv4.c	`6.14% <0%> (-35.39%)`	⬇️
subsys/bluetooth/controller/ll_sw/ull_conn.c	`16.67% <0%> (-33.4%)`	⬇️
subsys/bluetooth/controller/ll_sw/ull_sched.c	`50% <0%> (-33.34%)`	⬇️
... and 206 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e58df2c...eab5667. Read the comment docs.

ChaserTlss · 2019-04-08T05:15:36Z

Anyone review this? Maybe this patch is useful for me.

hongshui3000 · 2019-04-20T04:43:47Z

+1

hongshui3000 · 2019-05-09T09:40:45Z

What is the status of this pull request?

erwango · 2019-05-27T12:58:50Z

@pic16f887, sorry for late feedback on this. Had missed this proposal.
After having had a very quick look, this seems rather good, even if I can't comment on the proposed API.
Could you rebase the PR so we can start an active review?

Driver contains the following APIs: 1. Minimal command set needed for SD/MMC card initialization. 2. R1, R2, R3, R6, R7 response handlers. 3. Block write and read APIs. Signed-off-by: Yurii Hamann <yurii@hamann.site>

Added pinmux definitions for STM32F7 family Signed-off-by: Yurii Hamann <yurii@hamann.site>

Device tree binding support for STM32 MCUs Signed-off-by: Yurii Hamann <yurii@hamann.site>

1. Added SD/MMC interface dts_fixup definitons. 2. Added HAL header for STM32F7 family MCUs. Signed-off-by: Yurii Hamann <yurii@hamann.site>

Added SD/MMC interface enry in stm32f7 device tree file. Signed-off-by: Yurii Hamann <yurii@hamann.site>

Notes: 1. The drivers isn't ready for production use. 2. Block read/write API support only single block operations. 3. Currently no DMA support. Signed-off-by: Yurii Hamann <yurii@hamann.site>

1. Added pinmux definitions for SD/MMC interface. 2. Modified board dts file. 3. SD/MMC interface enabled in board config file. Signed-off-by: Yurii Hamann <yurii@hamann.site>

pic16f887 · 2019-05-28T10:32:59Z

@erwango, I have rebased the code.

erwango · 2019-07-25T16:07:28Z

@pic16f887, sorry once again for letting this PR not reviewed.
To get more attention on that PR, can you please split the generic API and STM32 parts?
The generic API should get more attention.

galak · 2019-09-19T17:21:27Z

@pic16f887 any updates on this?

avisconti · 2019-10-23T14:35:18Z

Adding support to SDMMC looks quite interesting.
Has it been abandoned?

pic16f887 · 2019-10-23T16:49:25Z

Currently I don't have a free time to finish it. You are free to use this code.

galak · 2020-01-30T11:19:44Z

Closing PR as its been marked stale for several months. Feel free to re-open and update if desired.

pic16f887 requested review from erwango, galak and MaureenHelm as code owners February 9, 2019 18:58

pic16f887 force-pushed the master branch 2 times, most recently from f28d6ca to e66404b Compare February 10, 2019 09:27

erwango added platform: STM32 ST Micro STM32 area: API Changes to public APIs labels May 27, 2019

pic16f887 force-pushed the master branch from e66404b to 7849983 Compare May 27, 2019 19:11

Yurii Hamann added 7 commits May 28, 2019 11:25

drivers: sdmmc: initial SD/MMC interface driver

416b902

Driver contains the following APIs: 1. Minimal command set needed for SD/MMC card initialization. 2. R1, R2, R3, R6, R7 response handlers. 3. Block write and read APIs. Signed-off-by: Yurii Hamann <yurii@hamann.site>

drivers: pinmux: stm32: SD/MMC pinmux for STM32F7 family

2ad8199

Added pinmux definitions for STM32F7 family Signed-off-by: Yurii Hamann <yurii@hamann.site>

dts: sdmmc: stm32: SD/MMC dts binding for STM32 MCUs

ca25522

Device tree binding support for STM32 MCUs Signed-off-by: Yurii Hamann <yurii@hamann.site>

soc: arm: stm32: SD/MMC SoC support for STM32F7

b656a5c

1. Added SD/MMC interface dts_fixup definitons. 2. Added HAL header for STM32F7 family MCUs. Signed-off-by: Yurii Hamann <yurii@hamann.site>

dts: arm: stm32: SD/MMC dts definitions for STM32F7

a602f40

Added SD/MMC interface enry in stm32f7 device tree file. Signed-off-by: Yurii Hamann <yurii@hamann.site>

drivers: sdmmc: initial SD/MMC driver for STM32

33ef6ee

Notes: 1. The drivers isn't ready for production use. 2. Block read/write API support only single block operations. 3. Currently no DMA support. Signed-off-by: Yurii Hamann <yurii@hamann.site>

boards: arm: stm32: SD/MMC support for STM32F746G discovery board

eab5667

1. Added pinmux definitions for SD/MMC interface. 2. Modified board dts file. 3. SD/MMC interface enabled in board config file. Signed-off-by: Yurii Hamann <yurii@hamann.site>

pic16f887 force-pushed the master branch from 7849983 to eab5667 Compare May 28, 2019 08:27

galak added the Stale PR label Sep 19, 2019

galak closed this Jan 30, 2020

anthonybrandon mentioned this pull request Mar 18, 2020

STM32 SDMMC disk access driver (based on stm32 cube HAL) #23555

Closed

erwango mentioned this pull request Mar 18, 2020

subsys/disk: add stm32 sdmmc disk access driver #23561

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial release of SD/MMC interface driver #13214

Initial release of SD/MMC interface driver #13214

pic16f887 commented Feb 9, 2019

zephyrbot commented Feb 9, 2019 •

edited

Loading

codecov-io commented Feb 9, 2019 •

edited

Loading

ChaserTlss commented Apr 8, 2019

hongshui3000 commented Apr 20, 2019

hongshui3000 commented May 9, 2019

erwango commented May 27, 2019

pic16f887 commented May 28, 2019

erwango commented Jul 25, 2019

galak commented Sep 19, 2019

avisconti commented Oct 23, 2019

pic16f887 commented Oct 23, 2019

galak commented Jan 30, 2020

Initial release of SD/MMC interface driver #13214

Initial release of SD/MMC interface driver #13214

Conversation

pic16f887 commented Feb 9, 2019

zephyrbot commented Feb 9, 2019 • edited Loading

codecov-io commented Feb 9, 2019 • edited Loading

Codecov Report

ChaserTlss commented Apr 8, 2019

hongshui3000 commented Apr 20, 2019

hongshui3000 commented May 9, 2019

erwango commented May 27, 2019

pic16f887 commented May 28, 2019

erwango commented Jul 25, 2019

galak commented Sep 19, 2019

avisconti commented Oct 23, 2019

pic16f887 commented Oct 23, 2019

galak commented Jan 30, 2020

zephyrbot commented Feb 9, 2019 •

edited

Loading

codecov-io commented Feb 9, 2019 •

edited

Loading