[Coverity CID :208919] Out-of-bounds read in drivers/sensor/adxl345/adxl345.c

[zephyrbot]

Static code scan issues found in file:

https://github.com/zephyrproject-rtos/zephyr/tree/master/drivers/sensor/adxl345/adxl345.c#L100

Category: Memory - illegal accesses
Function: adxl345_channel_get
Component: Drivers
CID: 208919

Details:

106             break;
107         case SENSOR_CHAN_ACCEL_Z:
108             adxl345_accel_convert(val, data->bufz[data->sample_number]);
109             data->sample_number++;
110             break;
111         case SENSOR_CHAN_ACCEL_XYZ:
>>>     CID 208919:    (OVERRUN)
>>>     Overrunning array "data->bufx" of 32 2-byte elements at element index 32 (byte offset 65) using index "data->sample_number" (which evaluates to 32).
112             adxl345_accel_convert(val++, data->bufx[data->sample_number]);
113             adxl345_accel_convert(val++, data->bufy[data->sample_number]);
114             adxl345_accel_convert(val,   data->bufz[data->sample_number]);
115             data->sample_number++;
116             break;
117         default:
94         if (data->sample_number > 32) {
95             data->sample_number = 0;
96         }
97    
98         switch (chan) {
99         case SENSOR_CHAN_ACCEL_X:
>>>     CID 208919:    (OVERRUN)
>>>     Overrunning array "data->bufx" of 32 2-byte elements at element index 32 (byte offset 65) using index "data->sample_number" (which evaluates to 32).
100             adxl345_accel_convert(val, data->bufx[data->sample_number]);
101             data->sample_number++;
102             break;
103         case SENSOR_CHAN_ACCEL_Y:
104             adxl345_accel_convert(val, data->bufy[data->sample_number]);
105             data->sample_number++;

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v32951/p12996.

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.

[carlescufi]

Fixed by #23931