-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sanitycheck samples/drivers/entropy/sample.drivers.entropy fails #23919
Labels
area: Samples
Samples
area: Sanitycheck
Sanitycheck has been renamed to Twister
bug
The issue is a bug, or the PR is fixing a bug
priority: low
Low impact/importance bug
Comments
jenmwms
added
area: Sanitycheck
Sanitycheck has been renamed to Twister
area: Samples
Samples
labels
Mar 30, 2020
Does this solve the problem? --- a/samples/drivers/entropy/sample.yaml
+++ b/samples/drivers/entropy/sample.yaml
@@ -11,4 +11,4 @@ tests:
regex:
- "Entropy Example! (.*)"
- "entropy device is (.*), name is (.*)"
- - "( 0x([0-9a-f]){2}){9}"
+ - "(\s*0x([0-9a-f]){2}){9}" |
This produces:
There seems to be escaping missing. The following works and fixes the problem: --- a/samples/drivers/entropy/sample.yaml
+++ b/samples/drivers/entropy/sample.yaml
@@ -11,4 +11,4 @@ tests:
regex:
- "Entropy Example! (.*)"
- "entropy device is (.*), name is (.*)"
- - "( 0x([0-9a-f]){2}){9}"
+ - "(\\s*0x([0-9a-f]){2}){9}" Result:
|
Can you submit a PR? :) |
chrta
added a commit
to lemonbeat/zephyr
that referenced
this issue
Apr 2, 2020
The last regex in the yaml file did not match when executing the test on an embedded target. The expected two spaces are not present at the beginning of the line. Fixes zephyrproject-rtos#23919 Signed-off-by: Christian Taedcke <christian.taedcke@lemonbeat.com>
nashif
pushed a commit
that referenced
this issue
Apr 3, 2020
The last regex in the yaml file did not match when executing the test on an embedded target. The expected two spaces are not present at the beginning of the line. Fixes #23919 Signed-off-by: Christian Taedcke <christian.taedcke@lemonbeat.com>
hakehuang
pushed a commit
to hakehuang/zephyr
that referenced
this issue
Apr 30, 2020
The last regex in the yaml file did not match when executing the test on an embedded target. The expected two spaces are not present at the beginning of the line. Fixes zephyrproject-rtos#23919 Signed-off-by: Christian Taedcke <christian.taedcke@lemonbeat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: Samples
Samples
area: Sanitycheck
Sanitycheck has been renamed to Twister
bug
The issue is a bug, or the PR is fixing a bug
priority: low
Low impact/importance bug
Describe the bug
The sanitycheck with the test samples/drivers/entropy/sample.drivers.entropy always fails for the board efm32pg_stk3402a. This seems to also be the case for other boards.
It seems that the regular expression
"( 0x([0-9a-f]){2}){9}"
in the filesample.yaml
expects two spaces at the beginning of the line, but there are no spaces, according to the filehandler.log
.According to
main.c
, the two spaces at the beginning of the line are printed. The two spaces at the beginning of the line are present in the console when using minicom.To Reproduce
Steps to reproduce the behavior:
./scripts/sanitycheck -p efm32pg_stk3402a --device-testing --device-serial /dev/ttyACM1 --west-flash="--reset-after-load" --test samples/drivers/entropy/sample.drivers.entropy -v
Expected behavior
The test should be PASSED
Impact
Only low impact, since only the sanitycheck reports that the entropy driver is not working, even if it is.
Console output
Console output:
samples/drivers/entropy/sample.drivers.entropy/handler.log:
Environment:
The text was updated successfully, but these errors were encountered: