Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eSPI KConfig overrides espi_config API channel selection in eSPI driver #24162

Closed
albertofloyd opened this issue Apr 7, 2020 · 0 comments · Fixed by #24213
Closed

eSPI KConfig overrides espi_config API channel selection in eSPI driver #24162

albertofloyd opened this issue Apr 7, 2020 · 0 comments · Fixed by #24213
Assignees
@albertofloyd
Labels
area: eSPI eSPI bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@albertofloyd
Copy link
Collaborator

albertofloyd commented Apr 7, 2020 •
edited
Loading

Describe the bug
eSPI KConfig channel enables overrides anything client driver is requesting.
i.e KConfig indicates following channels are supported
VW_CHANNEL
OOB_CHANNEL
FLASH_CHANNEL

If user decides only to enable only VW channel and Peripheral channel, eSPI driver still sends the wrong channel capabilities to eSPI partner. (VW/PC/OOB).

To Reproduce

  1. Change initialization in samples/drivers/espi/src/main.c under espi_init

  2. Reduce the amount of channels support

  3. build
    mkdir build; cd build
    cmake -DBOARD=board\mec15xx
    make

  4. Run the driver sample.
    All channels supported by the driver are advertised as enabled instead only the ones selected by client driver via espi_config API.

Expected behavior
Only the channels selected by the client driver should be advertised.

Impact
This deviates from eSPI API intention and slows debug due mismatched capabilities sicne eSPI analyzer to debug early handshake issues.
@albertofloyd albertofloyd added the bug The issue is a bug, or the PR is fixing a bug label Apr 7, 2020
@albertofloyd albertofloyd self-assigned this Apr 7, 2020
@carlescufi carlescufi added area: eSPI eSPI priority: low Low impact/importance bug labels Apr 8, 2020
albertofloyd added a commit to albertofloyd/zephyr that referenced this issue Apr 9, 2020
@albertofloyd
drivers: espi: xec: Validate channels espi configuration
dea5259 
Ensure driver's client channel configuration selection is used.
Fixes: zephyrproject-rtos#24162

Signed-off-by: Jose Alberto Meza <jose.a.meza.arellano@intel.com>
@albertofloyd albertofloyd mentioned this issue Apr 9, 2020
Merged
nashif pushed a commit that referenced this issue Apr 11, 2020
@albertofloyd @nashif
drivers: espi: xec: Validate channels espi configuration
f93c192 
Ensure driver's client channel configuration selection is used.
Fixes: #24162

Signed-off-by: Jose Alberto Meza <jose.a.meza.arellano@intel.com>
avisconti pushed a commit to avisconti/zephyr that referenced this issue Apr 15, 2020
@albertofloyd @avisconti
drivers: espi: xec: Validate channels espi configuration
dfd2bc0 
Ensure driver's client channel configuration selection is used.
Fixes: zephyrproject-rtos#24162

Signed-off-by: Jose Alberto Meza <jose.a.meza.arellano@intel.com>
hakehuang pushed a commit to hakehuang/zephyr that referenced this issue Jun 20, 2020
@albertofloyd @hakehuang
drivers: espi: xec: Validate channels espi configuration
1c3fef3 
Ensure driver's client channel configuration selection is used.
Fixes: zephyrproject-rtos#24162

Signed-off-by: Jose Alberto Meza <jose.a.meza.arellano@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@albertofloyd albertofloyd

Labels
area: eSPI eSPI bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

drivers: espi: xec: Validate channels espi configuration albertofloyd/zephyr
2 participants
@carlescufi @albertofloyd