Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couldn't flash image into up_squared using misc.py script. #24215

Closed
chen-png opened this issue Apr 9, 2020 · 4 comments · Fixed by #24218
Closed

Couldn't flash image into up_squared using misc.py script. #24215

chen-png opened this issue Apr 9, 2020 · 4 comments · Fixed by #24218
Assignees
Labels
bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug

Comments

@chen-png
Copy link
Collaborator

chen-png commented Apr 9, 2020

Describe the bug
for up_squared and acrn, we used the scripts/west_commands/runners/misc.py to flash a image, but now it met an flash error.
the related commit is 3b49d01, i reverted my repo before this commit, it was ok.

To Reproduce
Steps to reproduce the behavior:

  1. west build -b up_squared -p auto samples/hello_world
  2. west flash up_squared.sh
  3. See error

Screenshots or console output
Traceback (most recent call last):
File "/home/ztest/.local/bin/west", line 11, in
sys.exit(main())
File "/home/ztest/.local/lib/python3.6/site-packages/west/commands.py", line 116, in run
self.do_run(args, unknown)
File "/home/ztest/work/zephyrproject/zephyr/scripts/west_commands/flash.py", line 30, in do_run
do_run_common(self, my_args, runner_args)
File "/home/ztest/work/zephyrproject/zephyr/scripts/west_commands/run_common.py", line 147, in do_run_common
runner_config = load_runners_yaml(runners_yaml, user_args)
File "/home/ztest/work/zephyrproject/zephyr/scripts/west_commands/run_common.py", line 285, in load_runners_yaml
config = yaml.safe_load(f.read())
File "/home/ztest/.local/lib/python3.6/site-packages/yaml/init.py", line 162, in safe_load
return load(stream, SafeLoader)
File "/home/ztest/.local/lib/python3.6/site-packages/yaml/init.py", line 114, in load
return loader.get_single_data()
File "/home/ztest/.local/lib/python3.6/site-packages/yaml/constructor.py", line 41, in get_single_data
node = self.get_single_node()
File "/home/ztest/.local/lib/python3.6/site-packages/yaml/composer.py", line 36, in get_single_node
document = self.compose_document()
File "/home/ztest/.local/lib/python3.6/site-packages/yaml/composer.py", line 55, in compose_document
node = self.compose_node(None, None)
File "/home/ztest/.local/lib/python3.6/site-packages/yaml/composer.py", line 84, in compose_node
node = self.compose_mapping_node(anchor)
File "/home/ztest/.local/lib/python3.6/site-packages/yaml/composer.py", line 127, in compose_mapping_node
while not self.check_event(MappingEndEvent):
File "/home/ztest/.local/lib/python3.6/site-packages/yaml/parser.py", line 98, in check_event
self.current_event = self.state()
File "/home/ztest/.local/lib/python3.6/site-packages/yaml/parser.py", line 439, in parse_block_mapping_key
"expected , but found %r" % token.id, token.start_mark)
yaml.parser.ParserError: while parsing a block mapping
in "", line 2, column 1:
runners:
^
expected , but found '['
in "", line 20, column 2:
[]
^

Environment (please complete the following information):

  • OS: Fedora28
  • Toolchain: Zephyr-sdk-0.11.2
  • Commit ID: c413cca
@chen-png chen-png added the bug The issue is a bug, or the PR is fixing a bug label Apr 9, 2020
@chen-png
Copy link
Collaborator Author

chen-png commented Apr 9, 2020

@hakonfam Could you take a look of this? it's related to commit 3b49d01

@chen-png chen-png added the priority: medium Medium impact/importance bug label Apr 9, 2020
@chen-png
Copy link
Collaborator Author

chen-png commented Apr 9, 2020

this blocked QA test, so changed it's priority to medium.

hakonfam added a commit to hakonfam/zephyr that referenced this issue Apr 9, 2020
If a runner had no args, the format of the generated runners.yaml
was invalid due to missing indentation.

This commit fixes this issue by adding the required indentation.

This fixes issue zephyrproject-rtos#24215

Signed-off-by: Håkon Øye Amundsen <haakon.amundsen@nordicsemi.no>
@hakonfam
Copy link
Collaborator

hakonfam commented Apr 9, 2020

Please check #24218, it fixed the issue on my side.

@finikorg
Copy link
Collaborator

finikorg commented Apr 9, 2020

I have the same issue with up_square_adsp board, PR #22724 is failing.

carlescufi pushed a commit that referenced this issue Apr 9, 2020
If a runner had no args, the format of the generated runners.yaml
was invalid due to missing indentation.

This commit fixes this issue by adding the required indentation.

This fixes issue #24215

Signed-off-by: Håkon Øye Amundsen <haakon.amundsen@nordicsemi.no>
avisconti pushed a commit to avisconti/zephyr that referenced this issue Apr 15, 2020
If a runner had no args, the format of the generated runners.yaml
was invalid due to missing indentation.

This commit fixes this issue by adding the required indentation.

This fixes issue zephyrproject-rtos#24215

Signed-off-by: Håkon Øye Amundsen <haakon.amundsen@nordicsemi.no>
hakehuang pushed a commit to hakehuang/zephyr that referenced this issue Jun 20, 2020
If a runner had no args, the format of the generated runners.yaml
was invalid due to missing indentation.

This commit fixes this issue by adding the required indentation.

This fixes issue zephyrproject-rtos#24215

Signed-off-by: Håkon Øye Amundsen <haakon.amundsen@nordicsemi.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants