Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/lib/cmsis_dsp/transform failed on frdm_k64f board. #24701

Closed
chen-png opened this issue Apr 26, 2020 · 2 comments · Fixed by #24809
Closed

tests/lib/cmsis_dsp/transform failed on frdm_k64f board. #24701

chen-png opened this issue Apr 26, 2020 · 2 comments · Fixed by #24809
Assignees
@stephanosio
Labels
area: Tests Issues related to a particular existing or missing test bug The issue is a bug, or the PR is fixing a bug platform: NXP NXP priority: low Low impact/importance bug

Comments

@chen-png
Copy link
Collaborator

chen-png commented Apr 26, 2020 •
edited by stephanosio
Loading

To Reproduce
Steps to reproduce the behavior:

  1. west build -b frdm_k64f -p auto tests/lib/cmsis_dsp/transform
    -DCONF_FILE=prj_base.conf
    -DCONFIG_CMSIS_DSP_TEST_TRANSFORM_RQ15=y

  2. west flash

  3. See error

Screenshots or console output

*** Booting Zephyr OS build zephyr-v2.2.0-1974-g4d7d3a25c127  ***
Running test suite transform_rq15

starting test - test_arm_rfft_q15_noisy_32
PASS - test_arm_rfft_q15_noisy_32

starting test - test_arm_rifft_q15_noisy_32
**Assertion failed at WEST_TOPDIR/zephyr/tests/lib/cmsis_dsp/transform/src/rq15.c:145: test_arm_rifft_q15: (test_snr_error_q15(length, output, ref, SNR_ERROR_THRESH_IFFT) is false)
signal-to-noise ratio error limit exceeded**
FAIL - test_arm_rifft_q15_noisy_32

starting test - test_arm_rfft_q15_noisy_64
PASS - test_arm_rfft_q15_noisy_64

starting test - test_arm_rifft_q15_noisy_64
PASS - test_arm_rifft_q15_noisy_64

starting test - test_arm_rfft_q15_noisy_128
PASS - test_arm_rfft_q15_noisy_128

starting test - test_arm_rifft_q15_noisy_128
**Assertion failed at WEST_TOPDIR/zephyr/tests/lib/cmsis_dsp/transform/src/rq15.c:145: test_arm_rifft_q15: (test_snr_error_q15(length, output, ref, SNR_ERROR_THRESH_IFFT) is false)
signal-to-noise ratio error limit exceeded**
FAIL - test_arm_rifft_q15_noisy_128

starting test - test_arm_rfft_q15_noisy_256
PASS - test_arm_rfft_q15_noisy_256

starting test - test_arm_rfft_q15_noisy_512
PASS - test_arm_rfft_q15_noisy_512

starting test - test_arm_rfft_q15_noisy_1024
PASS - test_arm_rfft_q15_noisy_1024
....
starting test - test_arm_rfft_q15_step_2048
PASS - test_arm_rfft_q15_step_2048

starting test - test_arm_rfft_q15_step_4096
PASS - test_arm_rfft_q15_step_4096

Test suite transform_rq15 failed.

PROJECT EXECUTION FAILED

Environment (please complete the following information):

  • OS: fedora28
  • Toolchain: zephyr-sdk-0.11.2
  • Commit ID: 4d7d3a2
@chen-png chen-png added the bug The issue is a bug, or the PR is fixing a bug label Apr 26, 2020
@carlescufi carlescufi added area: Tests Issues related to a particular existing or missing test priority: low Low impact/importance bug labels Apr 28, 2020
@stephanosio
Copy link
Member

Note: CONFIG_CMSIS_DSP_TEST_TRANSFORM_RQ31 fails also.

@stephanosio
Copy link
Member

This is a bug (or at least an undocumented/very questionable behaviour) in the CMSIS-DSP inverse FFT implementation; I have filed an upstream issue for this: ARM-software/CMSIS_5#906

For now, I will implement workarounds in the tests to allow predictable operation.

stephanosio added a commit to stephanosio/zephyr that referenced this issue Apr 29, 2020
@stephanosio
tests: lib: cmsis_dsp: transform: Provide RIFFT bug workaround
58d5257 
This commit provides the workarounds for the CMSIS-DSP RIFFT input
buffer access bug reported in zephyrproject-rtos#24701.

The upstream issue for this bug is ARM-software/CMSIS_5#906.

Signed-off-by: Stephanos Ioannidis <root@stephanos.io>
@stephanosio stephanosio mentioned this issue Apr 29, 2020
Merged
MaureenHelm pushed a commit that referenced this issue May 4, 2020
@stephanosio @MaureenHelm
tests: lib: cmsis_dsp: transform: Provide RIFFT bug workaround
79d1b18 
This commit provides the workarounds for the CMSIS-DSP RIFFT input
buffer access bug reported in #24701.

The upstream issue for this bug is ARM-software/CMSIS_5#906.

Signed-off-by: Stephanos Ioannidis <root@stephanos.io>
hakehuang pushed a commit to hakehuang/zephyr that referenced this issue Jun 20, 2020
@stephanosio @hakehuang
tests: lib: cmsis_dsp: transform: Provide RIFFT bug workaround
97e06a1 
This commit provides the workarounds for the CMSIS-DSP RIFFT input
buffer access bug reported in zephyrproject-rtos#24701.

The upstream issue for this bug is ARM-software/CMSIS_5#906.

Signed-off-by: Stephanos Ioannidis <root@stephanos.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephanosio stephanosio

Labels
area: Tests Issues related to a particular existing or missing test bug The issue is a bug, or the PR is fixing a bug platform: NXP NXP priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests: lib: cmsis_dsp: transform: Provide RIFFT bug workaround stephanosio/zephyr
3 participants
@stephanosio @carlescufi @chen-png