Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adc: stm32g4: Fix ADC instances naming #24718

Closed
erwango opened this issue Apr 27, 2020 · 1 comment · Fixed by #24723
Closed

adc: stm32g4: Fix ADC instances naming #24718

erwango opened this issue Apr 27, 2020 · 1 comment · Fixed by #24723
Assignees
@erwango
Labels
area: ADC Analog-to-Digital Converter (ADC) bug The issue is a bug, or the PR is fixing a bug platform: STM32 ST Micro STM32

Comments

@erwango
Copy link
Member

erwango commented Apr 27, 2020

Describe the bug
In dts/arm/st/g4/stm32g4.dtsi, ADC instances were numbered starting from 0.
This does not match STM32 numbering scheme, there is no ADC_0 instance in ref manual, firt one is ADC_1.

Expected behavior
ADC instances description in device tree should respect ref manual naming convension.
@erwango erwango added bug The issue is a bug, or the PR is fixing a bug area: ADC Analog-to-Digital Converter (ADC) platform: STM32 ST Micro STM32 labels Apr 27, 2020
@erwango erwango self-assigned this Apr 27, 2020
@erwango
Copy link
Member Author

erwango commented Apr 27, 2020

^^@ABOSTM

ABOSTM added a commit to ABOSTM/zephyr that referenced this issue Apr 27, 2020
@ABOSTM
dts\arm\st\g4: Fix ADC instances naming
e9ddb9d 
ADC instances start with ADC_1
Fixes zephyrproject-rtos#24718

Signed-off-by: Alexandre Bourdiol <alexandre.bourdiol@st.com>
@ABOSTM ABOSTM mentioned this issue Apr 27, 2020
Merged
ioannisg pushed a commit that referenced this issue Apr 27, 2020
@ABOSTM @ioannisg
dts\arm\st\g4: Fix ADC instances naming
18a2192 
ADC instances start with ADC_1
Fixes #24718

Signed-off-by: Alexandre Bourdiol <alexandre.bourdiol@st.com>
sandeepbrcm pushed a commit to Broadcom/zephyr that referenced this issue Apr 30, 2020
@ABOSTM
dts\arm\st\g4: Fix ADC instances naming
5963302 
ADC instances start with ADC_1
Fixes zephyrproject-rtos#24718

Signed-off-by: Alexandre Bourdiol <alexandre.bourdiol@st.com>
hakehuang pushed a commit to hakehuang/zephyr that referenced this issue Jun 20, 2020
@ABOSTM @hakehuang
dts\arm\st\g4: Fix ADC instances naming
cfd6b4f 
ADC instances start with ADC_1
Fixes zephyrproject-rtos#24718

Signed-off-by: Alexandre Bourdiol <alexandre.bourdiol@st.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erwango erwango

Labels
area: ADC Analog-to-Digital Converter (ADC) bug The issue is a bug, or the PR is fixing a bug platform: STM32 ST Micro STM32
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dts\arm\st\g4: Fix ADC instances naming ABOSTM/zephyr
1 participant
@erwango