Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards: shields: esp_8266: There isn't CI tests enabled #25386

Closed
nandojve opened this issue May 16, 2020 · 0 comments · Fixed by #25387
Closed

boards: shields: esp_8266: There isn't CI tests enabled #25386

nandojve opened this issue May 16, 2020 · 0 comments · Fixed by #25387
Assignees
Labels
bug The issue is a bug, or the PR is fixing a bug Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
Milestone

Comments

@nandojve
Copy link
Member

Describe the bug
There is no tests to evaluate shield esp_8266 and their dependencies.

Impact
We can release code that don't work.

Aditional context
#25232

@nandojve nandojve added bug The issue is a bug, or the PR is fixing a bug Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. labels May 16, 2020
@nandojve nandojve added this to the v2.3.0 milestone May 16, 2020
@nandojve nandojve self-assigned this May 16, 2020
nandojve added a commit to nandojve/zephyr that referenced this issue May 16, 2020
The esp32 offload driver is used by shield esp_8266. This shield
doesn't have tests enabled to ensures that dependencies are ok.
This enables wifi sample to validate shield esp_8266 on CI and
consequently esp32 offload driver.

Fixes: zephyrproject-rtos#25386

Signed-off-by: Gerson Fernando Budke <nandojve@gmail.com>
carlescufi pushed a commit that referenced this issue May 16, 2020
The esp32 offload driver is used by shield esp_8266. This shield
doesn't have tests enabled to ensures that dependencies are ok.
This enables wifi sample to validate shield esp_8266 on CI and
consequently esp32 offload driver.

Fixes: #25386

Signed-off-by: Gerson Fernando Budke <nandojve@gmail.com>
krip-tip pushed a commit to krip-tip/zephyr-local that referenced this issue May 30, 2020
The esp32 offload driver is used by shield esp_8266. This shield
doesn't have tests enabled to ensures that dependencies are ok.
This enables wifi sample to validate shield esp_8266 on CI and
consequently esp32 offload driver.

Fixes: zephyrproject-rtos#25386

Signed-off-by: Gerson Fernando Budke <nandojve@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant