Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Coverity CID :210581] Dereference before null check in subsys/net/lib/sockets/socketpair.c #25788

Closed
zephyrbot opened this issue May 28, 2020 · 1 comment · Fixed by #25805
Closed

[Coverity CID :210581] Dereference before null check in subsys/net/lib/sockets/socketpair.c #25788

zephyrbot opened this issue May 28, 2020 · 1 comment · Fixed by #25805
Assignees
@pfalcon @jukkar @tbursztyka
Labels
area: Networking bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https://github.com/zephyrproject-rtos/zephyr/tree/4653b4e63f886a50ac7b72f8d47ba2950ab2dd0d/subsys/net/lib/sockets/socketpair.c

Category: Null pointer dereferences
Function: spair_sendmsg
Component: Networking
CID: 210581

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v32951/p12996.

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.
@zephyrbot zephyrbot added bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug labels May 28, 2020
@jukkar
Copy link
Member

jukkar commented May 28, 2020

@cfriedt can you check this one?

@cfriedt cfriedt mentioned this issue May 28, 2020
Merged
carlescufi pushed a commit that referenced this issue Jun 3, 2020
@cfriedt @carlescufi
net: socket: socketpair: initialize after NULL check
2715357 
Fixes #25788
Coverity-CID: 210581

Signed-off-by: Christopher Friedt <chrisfriedt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pfalcon pfalcon

@jukkar jukkar

@tbursztyka tbursztyka

Labels
area: Networking bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

net: sockets: socketpair: fix socketpair coverity issues
4 participants
@pfalcon @jukkar @tbursztyka @zephyrbot