Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coverity CID :210607] Uninitialized scalar variable in tests/net/socket/socketpair/src/test_socketpair_happy_path.c #25797

Closed
zephyrbot opened this issue May 28, 2020 · 2 comments · Fixed by #25805
Assignees
Labels
area: Networking bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https://github.com/zephyrproject-rtos/zephyr/tree/4653b4e63f886a50ac7b72f8d47ba2950ab2dd0d/tests/net/socket/socketpair/src/test_socketpair_happy_path.c#L139

Category: Uninitialized variables
Function: happy_path
Component: Tests
CID: 210607

Details:

133    
134             msghdr.msg_iov = &iovec;
135             msghdr.msg_iovlen = 1;
136             iovec.iov_base = (void *)expected_msg;
137             iovec.iov_len = expected_msg_len;
138    
>>>     CID 210607:  Uninitialized variables  (UNINIT)
>>>     Using uninitialized value "msghdr". Field "msghdr.msg_name" is uninitialized when calling "sendmsg". [Note: The source code implementation of the function has been overridden by a builtin model.]
139             res = sendmsg(sv[i], &msghdr, 0);
140    
141             zassert_not_equal(res, -1, "sendmsg(2) failed: %d", errno);
142             actual_msg_len = res;
143             zassert_equal(actual_msg_len, expected_msg_len,
144                       "did not sendmsg entire message");

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v32951/p12996.

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.

@zephyrbot zephyrbot added bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug labels May 28, 2020
@jukkar
Copy link
Member

jukkar commented May 28, 2020

@cfriedt can you take a look at this one?

@cfriedt
Copy link
Member

cfriedt commented May 28, 2020

@cfriedt can you take a look at this one?

Yeah, can it wait a couple of hours?

carlescufi pushed a commit that referenced this issue Jun 3, 2020
Fixes #25797
Coverity-CID: 210607

Signed-off-by: Christopher Friedt <chrisfriedt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Networking bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants